Add code to call skia's matchFamilyStyleCharacter API, which uses the

Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
patch from issue 1740593002 at patchset 140001 (http://crrev.com/1740593002#ps140001)

Committed: https://crrev.com/a56c8cae378b8110503230b358350fc755576f84
Cr-Commit-Position: refs/heads/master@{#388830}

[Ilya Kulshin, 2016-04-12 20:57:06]

Description was changed from

==========
Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

[Ilya Kulshin, 2016-04-12 21:24:09]

kulshin@chromium.org changed reviewers:
+ eae@chromium.org, jam@chromium.org

[Ilya Kulshin, 2016-04-12 21:24:09]

ptal.

This change was reviewed and lgtm'd as
https://codereview.chromium.org/1740593002, but I never landed the original and
it's been a while so I'd like to get a new set of lgtm's.

The only changes from the previous version were extending the test to include
more scripts.

[eae, 2016-04-13 15:53:42]

LGTM

[drott, 2016-04-13 17:36:20]

drott@chromium.org changed reviewers:
+ drott@chromium.org

[drott, 2016-04-13 17:36:21]

https://codereview.chromium.org/1883483002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/FontDescription.cpp (right):

https://codereview.chromium.org/1883483002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/FontDescription.cpp:281: SkFontStyle
FontDescription::skiaFontStyle() const
FontCacheSkia has a 

static inline SkFontStyle fontStyle(const FontDescription& fontDescription)

converter function. Can we converge on one of the two implementations?

[drott, 2016-04-13 17:36:54]

drott@chromium.org changed reviewers:
+ bungeman@chromium.org

[Ilya Kulshin, 2016-04-13 19:17:32]

On 2016/04/13 17:36:21, drott wrote:
>
https://codereview.chromium.org/1883483002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/fonts/FontDescription.cpp (right):
> 
>
https://codereview.chromium.org/1883483002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/fonts/FontDescription.cpp:281: SkFontStyle
> FontDescription::skiaFontStyle() const
> FontCacheSkia has a 
> 
> static inline SkFontStyle fontStyle(const FontDescription& fontDescription)
> 
> converter function. Can we converge on one of the two implementations?

I'm removing that implementation in favor of adding that functionality to
FontDescription in this very cl.

[drott, 2016-04-13 19:35:57]

> I'm removing that implementation in favor of adding that functionality to
FontDescription in this very cl.

Oh, sorry, my bad, I missed that. Thanks!
LGTM++

[Ilya Kulshin, 2016-04-15 21:57:18]

Description was changed from

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
COMMIT=false

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

[Ilya Kulshin, 2016-04-18 21:34:27]

Patchset #6 (id:100001) has been deleted

[Ilya Kulshin, 2016-04-19 00:12:19]

Patchset #3 (id:40001) has been deleted

[jam, 2016-04-19 18:27:38]

jam@chromium.org changed reviewers:
- jam@chromium.org

[Ilya Kulshin, 2016-04-19 21:34:58]

ptal.

I had to make a change to add an option to blink to bypass the fallback
path when running on Win7/Win8.0. This was needed to avoid going down
the Skia fallback path when IDWriteFontFallback was not available, which
was loading the system font collection.

I'd like to aim to land this tomorrow afternoon - please let me know
before then if you need more time to review the new changes.

[eae, 2016-04-20 00:29:20]

Still looks good to me.

[Ilya Kulshin, 2016-04-20 19:12:13]

Description was changed from

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
COMMIT=false

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

[Ilya Kulshin, 2016-04-20 19:12:23]

The CQ bit was checked by kulshin@chromium.org

[Ilya Kulshin, 2016-04-20 19:12:23]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org,
eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1883483002/#ps150001
(title: "Add expectation for font-fallback failure on Win7 and revert DEPS
change")

[commit-bot: I haz the power, 2016-04-20 19:12:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883483002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883483002/150001

[commit-bot: I haz the power, 2016-04-20 19:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 19:20:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Kulshin, 2016-04-20 20:02:12]

kulshin@chromium.org changed reviewers:
+ jochen@chromium.org

[Ilya Kulshin, 2016-04-20 20:02:13]

+jochen@ - could I get an owners approval for
third_party/WebKit/Source/web/win/WebFontRendering.*?

[jochen (gone - plz use gerrit), 2016-04-21 14:47:00]

lgtm

[Ilya Kulshin, 2016-04-21 17:06:31]

The CQ bit was checked by kulshin@chromium.org

[commit-bot: I haz the power, 2016-04-21 17:06:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883483002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883483002/150001

[commit-bot: I haz the power, 2016-04-21 18:50:44]

Description was changed from

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

[commit-bot: I haz the power, 2016-04-21 18:50:45]

Committed patchset #7 (id:150001)

[apacible, 2016-04-21 20:53:00]

A revert of this CL (patchset #7 id:150001) has been created in
https://codereview.chromium.org/1911863002/ by apacible@chromium.org.

The reason for reverting is: WebKit Win10 bots failing.

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/9115.

[commit-bot: I haz the power, 2016-04-22 19:36:50]

Description was changed from

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API

Add code to call skia's matchFamilyStyleCharacter API, which uses the
DirectWrite font fallback to find fonts for characters that do not exist
in the default font. The FontCache and FontDescription changes are
refactorings of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call into
DirectWrite.

This is part 3 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

patch from issue 1740593002 at patchset 140001
(http://crrev.com/1740593002#ps140001)

Committed: https://crrev.com/a56c8cae378b8110503230b358350fc755576f84
Cr-Commit-Position: refs/heads/master@{#388830}
==========

[commit-bot: I haz the power, 2016-04-22 19:36:51]

Patchset 7 (id:??) landed as
https://crrev.com/a56c8cae378b8110503230b358350fc755576f84
Cr-Commit-Position: refs/heads/master@{#388830}