Implement direct write fallback proxy

Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
Committed: https://crrev.com/267bf5ecb13595bb8c95fd6f115e556d6c1c56d4
Cr-Commit-Position: refs/heads/master@{#388262}

[Ilya Kulshin, 2016-04-12 20:49:33]

Patchset #1 (id:1) has been deleted

[Ilya Kulshin, 2016-04-12 20:49:40]

Patchset #1 (id:20001) has been deleted

[Ilya Kulshin, 2016-04-12 20:49:47]

Patchset #1 (id:40001) has been deleted

[Ilya Kulshin, 2016-04-12 20:49:56]

Patchset #1 (id:60001) has been deleted

[Ilya Kulshin, 2016-04-12 20:50:03]

Patchset #1 (id:80001) has been deleted

[Ilya Kulshin, 2016-04-12 20:56:12]

Description was changed from

==========
Implement direct write fallback proxy

Implement filter unit tests and add support for locale.
In progress: implement message definition and handler

BUG=
==========

to

==========
Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
==========

[Ilya Kulshin, 2016-04-12 21:21:12]

kulshin@chromium.org changed reviewers:
+ ananta@chromium.org, jschuh@chromium.org, scottmg@chromium.org

[Ilya Kulshin, 2016-04-12 21:21:13]

ptal

ananta@ - content/browser/*, content/child/*,
content/common/dwrite_text_analysis_source_win.*, content/test/*
jschuh@ - content/common/dwrite_font_proxy_messages.h

[ananta, 2016-04-12 23:44:40]

In the future, please split such patches into smaller sets. For e.g. new files
can be in one patch. Easier to review.

https://codereview.chromium.org/1846433005/diff/100001/content/browser/render...
File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
(right):

https://codereview.chromium.org/1846433005/diff/100001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:241: if
(!SUCCEEDED(factory2_->GetSystemFontFallback(&font_fallback_)))
Please change to if (FAILED here and everywhere in this file.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc:247: if
(!CreateFamily(family_index))
Please check for valid parameters here, especially the out ones.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.h:133: const
base::string16& GetName() { return family_name_; }
function name if inline should be family_name()

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.cc:35: if (!SUCCEEDED(
Please change to if (FAILED. Easier to read

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.cc:84: if
(!SUCCEEDED(family->GetFirstMatchingFont(
Please change to if (FAILED

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.h:41: sender_override_ =
sender_override;
Please move this to the cc file.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win_unittest.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win_unittest.cc:39:
.AddFamilyName(L"en-us", L"Arial")
Please split these statements up. Difficult to read.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.cc:14: if (text_position >=
text_.length())
Please check if the parameters like pointers, etc are valid and return
E_INVALIDARG or E_POINTER here and below.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.cc:20: HRESULT
TextAnalysisSource::GetNumberSubstitution(
newline between functions here and below

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:18: class CONTENT_EXPORT
TextAnalysisSource
Please add some comments about when this class is used, etc.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:26: HRESULT STDMETHODCALLTYPE
GetNumberSubstitution(
newline between methods.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:51:
Microsoft::WRL::ComPtr<IDWriteNumberSubstitution> number_substitution_;
Some comments about the non obvious members would be nice.

https://codereview.chromium.org/1846433005/diff/100001/content/test/dwrite_fo...
File content/test/dwrite_font_fake_sender_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/test/dwrite_fo...
content/test/dwrite_font_fake_sender_win.h:51: const base::string16& FontName()
{ return font_name_; }
Please change name to font_name()

[Ilya Kulshin, 2016-04-13 01:33:29]

https://codereview.chromium.org/1846433005/diff/100001/content/browser/render...
File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
(right):

https://codereview.chromium.org/1846433005/diff/100001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:241: if
(!SUCCEEDED(factory2_->GetSystemFontFallback(&font_fallback_)))
On 2016/04/12 23:44:39, ananta wrote:
> Please change to if (FAILED here and everywhere in this file. 

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc:247: if
(!CreateFamily(family_index))
On 2016/04/12 23:44:39, ananta wrote:
> Please check for valid parameters here, especially the out ones. 

Added a dcheck that font_family is not null and family_name is not empty.
CreateFamily validates family_index.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.h:133: const
base::string16& GetName() { return family_name_; }
On 2016/04/12 23:44:39, ananta wrote:
> function name if inline should be family_name()

Moved definition into cc.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.cc:35: if (!SUCCEEDED(
On 2016/04/12 23:44:39, ananta wrote:
> Please change to if (FAILED. Easier to read

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.cc:84: if
(!SUCCEEDED(family->GetFirstMatchingFont(
On 2016/04/12 23:44:39, ananta wrote:
> Please change to if (FAILED

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win.h:41: sender_override_ =
sender_override;
On 2016/04/12 23:44:39, ananta wrote:
> Please move this to the cc file.

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win_unittest.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win_unittest.cc:39:
.AddFamilyName(L"en-us", L"Arial")
On 2016/04/12 23:44:39, ananta wrote:
> Please split these statements up. Difficult to read.

This is just using the builder pattern. I find it easier to read than repeatedly
calling methods on a temporary, especially as the number of configuration grows.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.cc (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.cc:14: if (text_position >=
text_.length())
On 2016/04/12 23:44:39, ananta wrote:
> Please check if the parameters like pointers, etc are valid and return
> E_INVALIDARG or E_POINTER here and below.

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.cc:20: HRESULT
TextAnalysisSource::GetNumberSubstitution(
On 2016/04/12 23:44:39, ananta wrote:
> newline between functions here and below

Done.

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:18: class CONTENT_EXPORT
TextAnalysisSource
On 2016/04/12 23:44:39, ananta wrote:
> Please add some comments about when this class is used, etc.

This class doesn't really have any special use aside from being useful when
someone needs a really basic implementation of IDWriteTextAnalysisSource. Can
you explain what information you would like to see in a comment?

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:26: HRESULT STDMETHODCALLTYPE
GetNumberSubstitution(
On 2016/04/12 23:44:39, ananta wrote:
> newline between methods.

Added a comment to make it clear that these are overrides of the
IDWriteTextAnalysisSource interface, which don't require a newline (it's clearer
which methods are part of the interface when there are no linebreaks).

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:51:
Microsoft::WRL::ComPtr<IDWriteNumberSubstitution> number_substitution_;
On 2016/04/12 23:44:39, ananta wrote:
> Some comments about the non obvious members would be nice.

Added some explanatory comments in the header. The members just hold data that
is returned as-is on demand. Can you suggest what additional explanatory
comments you think are necessary?

https://codereview.chromium.org/1846433005/diff/100001/content/test/dwrite_fo...
File content/test/dwrite_font_fake_sender_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/test/dwrite_fo...
content/test/dwrite_font_fake_sender_win.h:51: const base::string16& FontName()
{ return font_name_; }
On 2016/04/12 23:44:39, ananta wrote:
> Please change name to font_name()

Done.

[scottmg, 2016-04-13 21:23:17]

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
(right):

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:237:
result->mapped_length = text.length();
Does the rest of MapCharactersResult need to be initialized for early return?

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
File
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc
(right):

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc:69:
EXPECT_GT(base::win::VERSION_WIN8_1, base::win::GetVersion());
EXPECT_LT(GetVersion(), WIN8_1) would be easier to read.

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc:216:

Can you add a test here for something that this is trying to address? (language
fallback or whatever)

https://codereview.chromium.org/1846433005/diff/120001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win_unittest.cc (right):

https://codereview.chromium.org/1846433005/diff/120001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win_unittest.cc:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
nit; no (c) (in a couple others too)

https://codereview.chromium.org/1846433005/diff/120001/content/common/dwrite_...
File content/common/dwrite_font_proxy_messages.h (right):

https://codereview.chromium.org/1846433005/diff/120001/content/common/dwrite_...
content/common/dwrite_font_proxy_messages.h:37:
IPC_STRUCT_MEMBER(DWriteFontStyle, font_style)
font_style doesn't seem to be used in OnMapCharacters()?

[Ilya Kulshin, 2016-04-13 22:31:29]

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
File content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc
(right):

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win.cc:237:
result->mapped_length = text.length();
On 2016/04/13 21:23:16, scottmg wrote:
> Does the rest of MapCharactersResult need to be initialized for early return?

The rest of the structure is default-initialized, which is fine for early
return, but I'll add initializers to be explicit.

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
File
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc
(right):

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc:69:
EXPECT_GT(base::win::VERSION_WIN8_1, base::win::GetVersion());
On 2016/04/13 21:23:16, scottmg wrote:
> EXPECT_LT(GetVersion(), WIN8_1) would be easier to read.
> 
> 

Done.

https://codereview.chromium.org/1846433005/diff/120001/content/browser/render...
content/browser/renderer_host/dwrite_font_proxy_message_filter_win_unittest.cc:216:

On 2016/04/13 21:23:16, scottmg wrote:
> Can you add a test here for something that this is trying to address?
(language
> fallback or whatever)

In a unittest, I'd rather not, since the ability to fallback on other languages
depends on having fonts for those languages installed on the system. The logic
for latin vs other fallback should be the same, at least as far as our code is
concerned. I could in theory mock out the system fallback, but that's a lot of
work for questionable benefit. I am adding an end-to-end test that validates
fallback as a blink layout test in part 3, so that case will ultimately still be
covered.

https://codereview.chromium.org/1846433005/diff/120001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/font_fallback_win_unittest.cc (right):

https://codereview.chromium.org/1846433005/diff/120001/content/child/dwrite_f...
content/child/dwrite_font_proxy/font_fallback_win_unittest.cc:1: // Copyright
(c) 2016 The Chromium Authors. All rights reserved.
On 2016/04/13 21:23:16, scottmg wrote:
> nit; no (c) (in a couple others too)

Done.

https://codereview.chromium.org/1846433005/diff/120001/content/common/dwrite_...
File content/common/dwrite_font_proxy_messages.h (right):

https://codereview.chromium.org/1846433005/diff/120001/content/common/dwrite_...
content/common/dwrite_font_proxy_messages.h:37:
IPC_STRUCT_MEMBER(DWriteFontStyle, font_style)
On 2016/04/13 21:23:16, scottmg wrote:
> font_style doesn't seem to be used in OnMapCharacters()?

Nice catch! Apparently DirectWrite doesn't care if I feed it all zeroes, but
good to preserve the style all the same.

[scottmg, 2016-04-13 23:18:33]

lgtm

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc (right):

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc:75:
mswr::ComPtr<IDWriteFontFallback> fontFallback;
font_fallback

[ananta, 2016-04-13 23:31:09]

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:18: class CONTENT_EXPORT
TextAnalysisSource
On 2016/04/13 01:33:29, Ilya Kulshin wrote:
> On 2016/04/12 23:44:39, ananta wrote:
> > Please add some comments about when this class is used, etc.
> 
> This class doesn't really have any special use aside from being useful when
> someone needs a really basic implementation of IDWriteTextAnalysisSource. Can
> you explain what information you would like to see in a comment?

If we have a use case in the current patch, pointing to that would be helpful
for reference.

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.h (right):

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.h:133: const
base::string16& GetName();
You can change this to family_name() and return the family_name_ member?

[Ilya Kulshin, 2016-04-13 23:59:40]

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
File content/common/dwrite_text_analysis_source_win.h (right):

https://codereview.chromium.org/1846433005/diff/100001/content/common/dwrite_...
content/common/dwrite_text_analysis_source_win.h:18: class CONTENT_EXPORT
TextAnalysisSource
On 2016/04/13 23:31:09, ananta wrote:
> On 2016/04/13 01:33:29, Ilya Kulshin wrote:
> > On 2016/04/12 23:44:39, ananta wrote:
> > > Please add some comments about when this class is used, etc.
> > 
> > This class doesn't really have any special use aside from being useful when
> > someone needs a really basic implementation of IDWriteTextAnalysisSource.
Can
> > you explain what information you would like to see in a comment?
> 
> If we have a use case in the current patch, pointing to that would be helpful
> for reference.

Such a comment would certainly become outdated, and would be hard to notice that
it needs to be updated at that time. Since TextAnalysisSource is not a common
token, actual users can be easily found with codesearch.

On the question of being used specifically in this patch, it is used by
DWriteFontProxyMessageFilter::OnMapCharacters and
FontFallbackUnitTest::MapCharacters.

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc (right):

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc:75:
mswr::ComPtr<IDWriteFontFallback> fontFallback;
On 2016/04/13 23:18:33, scottmg wrote:
> font_fallback

Done.

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
File content/child/dwrite_font_proxy/dwrite_font_proxy_win.h (right):

https://codereview.chromium.org/1846433005/diff/140001/content/child/dwrite_f...
content/child/dwrite_font_proxy/dwrite_font_proxy_win.h:133: const
base::string16& GetName();
On 2016/04/13 23:31:09, ananta wrote:
> You can change this to family_name() and return the family_name_ member?

I dislike the idea of using different naming conventions for functions within
the same class that only differ in implementation details (in this case, being
inlined vs not). I also would not want to force someone to have to rename the
function if the implementation happens to grow in complexity.

[ananta, 2016-04-15 20:15:51]

lgtm

[Ilya Kulshin, 2016-04-15 20:25:46]

kulshin@chromium.org changed reviewers:
+ jochen@chromium.org

[Ilya Kulshin, 2016-04-15 20:25:46]

+jochen@ - could I get an owners approval for content/common/* and
content/test/*?
jschuh@ - could I get an owners approval for
content/common/dwrite_font_proxy_messages.h?

[jschuh, 2016-04-15 21:43:27]

On 2016/04/15 20:25:46, Ilya Kulshin wrote:
> +jochen@ - could I get an owners approval for content/common/* and
> content/test/*?
> jschuh@ - could I get an owners approval for
> content/common/dwrite_font_proxy_messages.h?

ipc security lgtm

[jochen (gone - plz use gerrit), 2016-04-17 17:13:41]

lgtm

[Ilya Kulshin, 2016-04-19 18:45:21]

The CQ bit was checked by kulshin@chromium.org

[Ilya Kulshin, 2016-04-19 18:45:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
scottmg@chromium.org, ananta@chromium.org, jschuh@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1846433005/#ps280001
(title: "Add a missing SUCCEEDED call")

[commit-bot: I haz the power, 2016-04-19 18:45:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846433005/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846433005/280001

[commit-bot: I haz the power, 2016-04-19 18:57:25]

Description was changed from

==========
Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
==========

to

==========
Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
==========

[commit-bot: I haz the power, 2016-04-19 18:57:26]

Committed patchset #10 (id:280001)

[commit-bot: I haz the power, 2016-04-22 19:14:33]

Description was changed from

==========
Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056
==========

to

==========
Implement direct write fallback proxy

This change implements an IDWriteFontFallback that uses IPC to talk to
the browser process and obtain font fallback data.

This is part 2 of a three part change.
1: https://codereview.chromium.org/1878843002/
   Adds support for specifying a font fallback in skia
2: https://codereview.chromium.org/1846433005/
   Implements the fallback proxy in Chromium
3: https://codereview.chromium.org/1883483002/
   Adds code to blink to call skia's fallback API

BUG=459056

Committed: https://crrev.com/267bf5ecb13595bb8c95fd6f115e556d6c1c56d4
Cr-Commit-Position: refs/heads/master@{#388262}
==========

[commit-bot: I haz the power, 2016-04-22 19:14:35]

Patchset 10 (id:??) landed as
https://crrev.com/267bf5ecb13595bb8c95fd6f115e556d6c1c56d4
Cr-Commit-Position: refs/heads/master@{#388262}