Use Skia's matchFamilyStyleCharacter API for font fallback

Add code to call skia's matchFamilyStyleCharacter API, which
uses the DirectWrite font fallback to find fonts for
characters that do not exist in the default font.
The FontCache and FontDescription changes are refactorings
of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call
into DirectWrite.

This requires skia change https://codereview.chromium.org/1740533003/,
which ensures that the font fallback is initialized prior to
sandbox start.

BUG=459056

[Ilya Kulshin, 2016-02-29 21:48:02]

Patchset #2 (id:20001) has been deleted

[Ilya Kulshin, 2016-02-29 22:38:40]

Description was changed from

==========
Create a dwrite font fallback at startup and use it.

BUG=
==========

to

==========
Create a DirectWrite font fallback at startup and use it.
The FontCache and FontDescription changes are refactorings
of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call
into DirectWrite.

This requires skia change https://codereview.chromium.org/1740533003/

BUG=459056
==========

[Ilya Kulshin, 2016-02-29 22:47:16]

kulshin@chromium.org changed reviewers:
+ eae@chromium.org, jam@chromium.org

[Ilya Kulshin, 2016-02-29 22:47:17]

ptal:

eae@ - third_party/WebKit/Source/platform/fonts/*
jam@ - content/child/font_warmup_win.cc

[eae, 2016-02-29 23:11:26]

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontDescription.cpp (right):

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontDescription.cpp:284: int fontWeight
= (weight() - FontWeight100 + 1) * 100;
We might want to add a helper for this. numericFontWeight for instance?

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:147: // If the
font description has a locale, use that. Otherwise, Skia will fall back
Wrap at 80 col, you'll probably do a better job of doing so then the pending
batch job.

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:153:
localeCount = 1;
This is set but never used. Please remove.

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:158: const
char* skiaFamilyName = reinterpret_cast<const char*>(fontDescriptionFamilyName);
Elsewhere we convert the family name to utf8 before passing it to Skia. 

Cstring familyName = fontDescription.family().family().utf8();
const char* skiaFamilyName = familyName.data();

[Ilya Kulshin, 2016-03-01 03:31:14]

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontDescription.cpp (right):

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontDescription.cpp:284: int fontWeight
= (weight() - FontWeight100 + 1) * 100;
On 2016/02/29 23:11:26, eae wrote:
> We might want to add a helper for this. numericFontWeight for instance?

Done. Added a helper, although perhaps the actual numeric values of
FontWeightXXX should just be XXX (but I'm not going to make that change at this
time).

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp (right):

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:147: // If the
font description has a locale, use that. Otherwise, Skia will fall back
On 2016/02/29 23:11:26, eae wrote:
> Wrap at 80 col, you'll probably do a better job of doing so then the pending
> batch job.

Done.

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:153:
localeCount = 1;
On 2016/02/29 23:11:26, eae wrote:
> This is set but never used. Please remove.

This is used in the call to matchFamilyStyleCharacter.

https://codereview.chromium.org/1740593002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp:158: const
char* skiaFamilyName = reinterpret_cast<const char*>(fontDescriptionFamilyName);
On 2016/02/29 23:11:26, eae wrote:
> Elsewhere we convert the family name to utf8 before passing it to Skia. 
> 
> Cstring familyName = fontDescription.family().family().utf8();
> const char* skiaFamilyName = familyName.data();

Oh, not sure how I missed that API. That works much better, thanks for the tip!

[jam, 2016-03-01 16:40:05]

On 2016/02/29 22:47:17, Ilya Kulshin wrote:
> ptal:
> 
> eae@ - third_party/WebKit/Source/platform/fonts/*
> jam@ - content/child/font_warmup_win.cc

you're an owner there so you don't need another owner for review.. can eae
review all of this?

[jam, 2016-03-01 20:03:19]

lgtm

[jam, 2016-03-01 20:05:54]

actually why are the two file in content/child duplicating code instead of
sharing it?

[eae, 2016-03-01 20:06:05]

LGTM, thank you.

[Ilya Kulshin, 2016-03-01 20:11:01]

On 2016/03/01 20:05:54, jam wrote:
> actually why are the two file in content/child duplicating code instead of
> sharing it?

For such a small amount of code (one QueryInterface and one actual function
call), didn't really seem worthwhile to extract a shared function. I could do
that if you feel strongly about it, but the benefit seems to be minimal.

[jam, 2016-03-01 20:22:11]

On 2016/03/01 20:11:01, Ilya Kulshin wrote:
> On 2016/03/01 20:05:54, jam wrote:
> > actually why are the two file in content/child duplicating code instead of
> > sharing it?
> 
> For such a small amount of code (one QueryInterface and one actual function
> call), didn't really seem worthwhile to extract a shared function. I could do
> that if you feel strongly about it, but the benefit seems to be minimal.

well it's almost 10 lines of code, and there's the
blink::WebFontRendering::setSkiaFontManager. i think better to have a shared
method.

[Ilya Kulshin, 2016-03-07 22:20:29]

Patchset #5 (id:100001) has been deleted

[Ilya Kulshin, 2016-03-07 23:46:46]

Description was changed from

==========
Create a DirectWrite font fallback at startup and use it.
The FontCache and FontDescription changes are refactorings
of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call
into DirectWrite.

This requires skia change https://codereview.chromium.org/1740533003/

BUG=459056
==========

to

==========
Add code to call skia's matchFamilyStyleCharacter API, which
uses the DirectWrite font fallback to find fonts for
characters that do not exist in the default font.
The FontCache and FontDescription changes are refactorings
of shared code out of FontCacheAndroid and FontCacheSkiaWin.
The FontCacheSkiaWin change adds logic to call skia's
matchFamilyStyleCharacter API, which will ultimately call
into DirectWrite.

This requires skia change https://codereview.chromium.org/1740533003/,
which ensures that the font fallback is initialized prior to
sandbox start.

BUG=459056
==========