[Password Manager] HTML parsing based client-side form type classifier

components/autofill/content/renderer/form_classifier.h

Index: components/autofill/content/renderer/form_classifier.h
diff --git a/components/autofill/content/renderer/form_classifier.h b/components/autofill/content/renderer/form_classifier.h
new file mode 100644
index 0000000000000000000000000000000000000000..2ce96c3c3f2b9f44702715e5c6ba84498ddf5423
--- /dev/null
+++ b/components/autofill/content/renderer/form_classifier.h
@@ -0,0 +1,14 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "third_party/WebKit/public/web/WebFormElement.h"
+
+namespace autofill {
+
+// Checks if |form| is eligible for password generation. If yes, sets the name
+// of the generation field to |generation_field| and returns true. Otherwise,

[vabr (Chromium), 2016/06/10 13:22:12]

nit: It might not be completely clear what a "generation field" is. Perhaps we
could call it "field where Chrome should generate a password"?

+// returns false (w/o any changes of |generation_field|).

[vabr (Chromium), 2016/06/10 13:22:12]

nit: changes of -> changes to

+bool ClassifyFormAndFindGenerationField(const blink::WebFormElement& form,

[vabr (Chromium), 2016/06/10 13:22:12]

You should just forward-declare blink::WebFormElement (keep the #include for the
.cc file) and you should also forward-declare base::string16.

http://dev.chromium.org/developers/coding-style#TOC-Forward-declarations-vs.-...

+                                        base::string16* generation_field);
+}