components/autofill.gypi - Issue 1883183002: [Password Manager] HTML parsing based client-side form type classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill.gypi

Issue 1883183002: [Password Manager] HTML parsing based client-side form type classifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed the signature of ClassifyFormAndFindGenerationField Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/autofill/form_classifier_browsertest.cc ('K') | « chrome/renderer/autofill/form_classifier_browsertest.cc ('k') | components/autofill/content/renderer/BUILD.gn » ('j') | components/autofill/content/renderer/form_classifier.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill.gypi

diff --git a/components/autofill.gypi b/components/autofill.gypi

index 7d4ab6bccd6e9a90421476cd227237e750212271..d43cd99659d43cb3b190cd8ec2e362857fbac61c 100644

--- a/components/autofill.gypi

+++ b/components/autofill.gypi

@@ -490,6 +490,8 @@

'autofill/content/renderer/form_autofill_util.h',

'autofill/content/renderer/form_cache.cc',

'autofill/content/renderer/form_cache.h',

+ 'autofill/content/renderer/form_classifier.cc',

vabr (Chromium) 2016/06/10 13:22:11 Where do we plan to use form_classifier? If only i

kolos1 2016/06/13 14:27:34 As we discussed in person, the form classifier wil

+ 'autofill/content/renderer/form_classifier.h',

'autofill/content/renderer/page_click_listener.h',

'autofill/content/renderer/page_click_tracker.cc',

'autofill/content/renderer/page_click_tracker.h',