components/autofill/content/renderer/form_classifier.h - Issue 1883183002: [Password Manager] HTML parsing based client-side form type classifier

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/autofill/content/renderer/form_classifier.h

Issue 1883183002: [Password Manager] HTML parsing based client-side form type classifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed the signature of ClassifyFormAndFindGenerationField Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/autofill.gypi ('K') | « components/autofill/content/renderer/BUILD.gn ('k') | components/autofill/content/renderer/form_classifier.cc » ('j') | components/autofill/content/renderer/form_classifier.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "third_party/WebKit/public/web/WebFormElement.h"

	6

	7 namespace autofill {

	8

	9 // Checks if \|form\| is eligible for password generation. If yes, sets the name

	10 // of the generation field to \|generation_field\| and returns true. Otherwise,
	vabr (Chromium) 2016/06/10 13:22:12 nit: It might not be completely clear what a "gene nit: It might not be completely clear what a "generation field" is. Perhaps we could call it "field where Chrome should generate a password"?
	11 // returns false (w/o any changes of \|generation_field\|).
	vabr (Chromium) 2016/06/10 13:22:12 nit: changes of -> changes to nit: changes of -> changes to
	12 bool ClassifyFormAndFindGenerationField(const blink::WebFormElement& form,
	vabr (Chromium) 2016/06/10 13:22:12 You should just forward-declare blink::WebFormElem You should just forward-declare blink::WebFormElement (keep the #include for the .cc file) and you should also forward-declare base::string16. http://dev.chromium.org/developers/coding-style#TOC-Forward-declarations-vs.-...
	13 base::string16* generation_field);

	14 }

OLD	NEW