[api] Bring back finalizers on global handles

[api] Bring back finalizers on global handles

Seems like node.js depends on it in many places. At least try to get rid
of WeakCallbackData vs WeakCallbackInfo

BUG=
R=hpayer@chromium.org
LOG=y

Committed: https://crrev.com/00a589d9ffdfcd73126dffcf1683f811305d6752
Cr-Commit-Position: refs/heads/master@{#35528}

[noordhuis, 2016-04-14 14:52:36]

https://codereview.chromium.org/1883173002/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/1883173002/diff/1/src/global-handles.cc#newco...
src/global-handles.cc:357: nullptr};
Femto-nit, but other places that depend on v8::kInternalFieldsInWeakCallback
seem to use a for loop to initialize the array elements.

[jochen (gone - plz use gerrit), 2016-04-14 15:16:04]

https://codereview.chromium.org/1883173002/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

https://codereview.chromium.org/1883173002/diff/1/src/global-handles.cc#newco...
src/global-handles.cc:357: nullptr};
On 2016/04/14 at 14:52:36, noordhuis wrote:
> Femto-nit, but other places that depend on v8::kInternalFieldsInWeakCallback
seem to use a for loop to initialize the array elements.

i copied this from
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/global-hand...

[jochen (gone - plz use gerrit), 2016-04-15 09:12:07]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-15 09:12:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883173002/1

[commit-bot: I haz the power, 2016-04-15 09:38:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-15 09:38:51]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-04-15 12:54:54]

lgtm

[jochen (gone - plz use gerrit), 2016-04-15 12:55:17]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-04-15 12:55:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1883173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1883173002/1

[commit-bot: I haz the power, 2016-04-15 12:57:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-15 12:59:58]

Description was changed from

==========
[api] Bring back finalizers on global handles

Seems like node.js depends on it in many places. At least try to get rid
of WeakCallbackData vs WeakCallbackInfo

BUG=
R=hpayer@chromium.org
LOG=y
==========

to

==========
[api] Bring back finalizers on global handles

Seems like node.js depends on it in many places. At least try to get rid
of WeakCallbackData vs WeakCallbackInfo

BUG=
R=hpayer@chromium.org
LOG=y

Committed: https://crrev.com/00a589d9ffdfcd73126dffcf1683f811305d6752
Cr-Commit-Position: refs/heads/master@{#35528}
==========

[commit-bot: I haz the power, 2016-04-15 12:59:59]

Patchset 1 (id:??) landed as
https://crrev.com/00a589d9ffdfcd73126dffcf1683f811305d6752
Cr-Commit-Position: refs/heads/master@{#35528}