Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Unified Diff: src/global-handles.h

Issue 1883173002: [api] Bring back finalizers on global handles (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/global-handles.cc » ('j') | src/global-handles.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/global-handles.h
diff --git a/src/global-handles.h b/src/global-handles.h
index ac8487b19fb6ee7b2127b9333e279f70e34e38f3..4339c2dda3a07cd65d256ecff817778ee0956ef0 100644
--- a/src/global-handles.h
+++ b/src/global-handles.h
@@ -96,7 +96,6 @@ struct ObjectGroupRetainerInfo {
RetainedObjectInfo* info;
};
-
enum WeaknessType {
NORMAL_WEAK, // Embedder gets a handle to the dying object.
// In the following cases, the embedder gets the parameter they passed in
@@ -105,10 +104,11 @@ enum WeaknessType {
// objects through this interface would be GC unsafe so in that case the
// embedder gets a null pointer instead.
PHANTOM_WEAK,
- PHANTOM_WEAK_2_INTERNAL_FIELDS
+ PHANTOM_WEAK_2_INTERNAL_FIELDS,
+ // Like NORMAL_WEAK, but uses WeakCallbackInfo instead of WeakCallbackData.
+ FINALIZER_WEAK,
};
-
class GlobalHandles {
public:
~GlobalHandles();
« no previous file with comments | « include/v8.h ('k') | src/global-handles.cc » ('j') | src/global-handles.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698