Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1882973002: Allow targets to override the output directory. (Closed)

Created:
4 years, 8 months ago by brettw
Modified:
4 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@output_dir
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow targets to override the output directory. This uses the new output_dir override of GN (see https://codereview.chromium.org/1887533003) in the tool definitions to allow targets to override this location. Committed: https://crrev.com/c2c1dcfdf6d7cd90d7626ad9a5bdf5fb4ba8dda3 Cr-Commit-Position: refs/heads/master@{#387432}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M build/toolchain/gcc_toolchain.gni View 6 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brettw
4 years, 8 months ago (2016-04-13 21:26:11 UTC) #2
Robert Sesek
LGTM. Mac version is here: https://codereview.chromium.org/1886813003
4 years, 8 months ago (2016-04-14 17:24:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882973002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882973002/60001
4 years, 8 months ago (2016-04-14 20:48:19 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 21:37:10 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 21:38:44 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c2c1dcfdf6d7cd90d7626ad9a5bdf5fb4ba8dda3
Cr-Commit-Position: refs/heads/master@{#387432}

Powered by Google App Engine
This is Rietveld 408576698