Add an output_dir override to GN.

Add an output_dir override to GN.

This adds support for the ability for targets to override their output
directory. The tool defines a default output directory in terms of the normal
patterns. The target can optionally supply an override, and the tool uses the
new {{output_dir}} pattern when specifying tool output to express the result of
the default-or-override.

Committed: https://crrev.com/f2eba7f76b6effb82ddce70d2bb227f4e25b1f69
Cr-Commit-Position: refs/heads/master@{#387366}

[brettw, 2016-04-13 21:22:05]

brettw@chromium.org changed reviewers:
+ rsesek@chromium.org

[brettw, 2016-04-13 21:22:10]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-13 21:22:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533003/20001

[brettw, 2016-04-13 21:25:44]

See https://codereview.chromium.org/1882973002 for the Posix implementation for
the toolchain. That will have to be landed (with the corresponding Windows part)
after the GN binary has rolled.

[commit-bot: I haz the power, 2016-04-13 22:04:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-13 22:04:38]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-04-14 01:38:40]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-04-14 01:38:40]

lgtm, though I didn't stare at this too closely.

[Robert Sesek, 2016-04-14 17:23:20]

LGTM

https://codereview.chromium.org/1887533003/diff/20001/tools/gn/target.h
File tools/gn/target.h (right):

https://codereview.chromium.org/1887533003/diff/20001/tools/gn/target.h#newco...
tools/gn/target.h:106: SourceDir output_dir() const { return output_dir_; }
Looks like this could be const& if desired.

[brettw, 2016-04-14 17:26:26]

const

[brettw, 2016-04-14 17:26:27]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-04-14 17:26:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1887533003/#ps40001
(title: "const")

[commit-bot: I haz the power, 2016-04-14 17:26:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1887533003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1887533003/40001

[brettw, 2016-04-14 17:27:47]

https://codereview.chromium.org/1887533003/diff/20001/tools/gn/target.h
File tools/gn/target.h (right):

https://codereview.chromium.org/1887533003/diff/20001/tools/gn/target.h#newco...
tools/gn/target.h:106: SourceDir output_dir() const { return output_dir_; }
On 2016/04/14 17:23:20, Robert Sesek wrote:
> Looks like this could be const& if desired.

Thanks, that's what I meant!

[commit-bot: I haz the power, 2016-04-14 18:14:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-14 18:16:42]

Description was changed from

==========
Add an output_dir override to GN.

This adds support for the ability for targets to override their output
directory. The tool defines a default output directory in terms of the normal
patterns. The target can optionally supply an override, and the tool uses the
new {{output_dir}} pattern when specifying tool output to express the result of
the default-or-override.
==========

to

==========
Add an output_dir override to GN.

This adds support for the ability for targets to override their output
directory. The tool defines a default output directory in terms of the normal
patterns. The target can optionally supply an override, and the tool uses the
new {{output_dir}} pattern when specifying tool output to express the result of
the default-or-override.

Committed: https://crrev.com/f2eba7f76b6effb82ddce70d2bb227f4e25b1f69
Cr-Commit-Position: refs/heads/master@{#387366}
==========

[commit-bot: I haz the power, 2016-04-14 18:16:43]

Patchset 3 (id:??) landed as
https://crrev.com/f2eba7f76b6effb82ddce70d2bb227f4e25b1f69
Cr-Commit-Position: refs/heads/master@{#387366}