Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1886813003: [Mac/iOS/GN] Allow targets to override the output directory. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/iOS/GN] Allow targets to override the output directory. This uses the new output_dir override of GN (see https://codereview.chromium.org/1887533003) in the tool definitions to allow targets to override this location. Updates the framework_bundle() template to specify an output_dir as well. R=brettw@chromium.org BUG=297668 Committed: https://crrev.com/3c470b6d0ef8276f0aea16385ae68bfa6bca969c Cr-Commit-Position: refs/heads/master@{#387464}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M build/config/mac/rules.gni View 1 chunk +2 lines, -1 line 0 comments Download
M build/toolchain/mac/BUILD.gn View 6 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Robert Sesek
4 years, 8 months ago (2016-04-14 17:24:13 UTC) #2
brettw
LGTM, you'll need this to land first: https://codereview.chromium.org/1888173002
4 years, 8 months ago (2016-04-14 20:23:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1886813003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1886813003/20001
4 years, 8 months ago (2016-04-14 20:56:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 22:41:56 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 22:42:56 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c470b6d0ef8276f0aea16385ae68bfa6bca969c
Cr-Commit-Position: refs/heads/master@{#387464}

Powered by Google App Engine
This is Rietveld 408576698