Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: chrome/installer/util/conditional_work_item_list.h

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/conditional_work_item_list.h
diff --git a/chrome/installer/util/conditional_work_item_list.h b/chrome/installer/util/conditional_work_item_list.h
index ae5cdc9c7645da8c83019bd864a4ba4c01b0e47d..72fa09000ec4ec9c5eac3b2fa4b445f79b615fd7 100644
--- a/chrome/installer/util/conditional_work_item_list.h
+++ b/chrome/installer/util/conditional_work_item_list.h
@@ -17,15 +17,17 @@ class ConditionalWorkItemList : public WorkItemList {
explicit ConditionalWorkItemList(Condition* condition);
~ConditionalWorkItemList() override;
+ private:
+ // WorkItemList:
+
// If condition_->ShouldRun() returns true, then execute the items in this
// list and return true iff they all succeed. If condition_->ShouldRun()
// returns false, does nothing and returns true.
- bool Do() override;
+ bool DoImpl() override;
// Does a rollback of the items (if any) that were run in Do.
- void Rollback() override;
+ void RollbackImpl() override;
- protected:
// Pointer to a Condition that is used to determine whether to run this
// WorkItemList.
scoped_ptr<Condition> condition_;
grt (UTC plus 2) 2016/04/27 17:29:16 std::unique_ptr
fdoray 2016/05/02 20:10:00 Rebase took care of this.

Powered by Google App Engine
This is Rietveld 408576698