Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3114)

Unified Diff: chrome/installer/util/conditional_work_item_list.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/conditional_work_item_list.cc
diff --git a/chrome/installer/util/conditional_work_item_list.cc b/chrome/installer/util/conditional_work_item_list.cc
index fcf195584bc3b30881b0bd3972e8218914ee188f..d3495e3c1e713553722eaf4b265b4d72b95f78a0 100644
--- a/chrome/installer/util/conditional_work_item_list.cc
+++ b/chrome/installer/util/conditional_work_item_list.cc
@@ -13,20 +13,20 @@ ConditionalWorkItemList::ConditionalWorkItemList(Condition* condition)
ConditionalWorkItemList::~ConditionalWorkItemList() {}
-bool ConditionalWorkItemList::Do() {
+bool ConditionalWorkItemList::DoImpl() {
VLOG(1) << "Evaluating " << log_message_ << " condition...";
if (condition_.get() && condition_->ShouldRun()) {
VLOG(1) << "Beginning conditional work item list";
- return WorkItemList::Do();
+ return WorkItemList::DoImpl();
}
VLOG(1) << "No work to do in condition work item list "
<< log_message_;
return true;
}
-void ConditionalWorkItemList::Rollback() {
+void ConditionalWorkItemList::RollbackImpl() {
VLOG(1) << "Rolling back conditional list " << log_message_;
- WorkItemList::Rollback();
+ WorkItemList::RollbackImpl();
}
// Pre-defined conditions:

Powered by Google App Engine
This is Rietveld 408576698