chrome/installer/setup/update_active_setup_version_work_item.cc - Issue 1882923003: Add best-effort/allow rollback flags on WorkItem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/update_active_setup_version_work_item.cc

Issue 1882923003: Add best-effort/allow rollback flags on WorkItem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simple_list_tests

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/installer/setup/install_worker.cc ('K') | « chrome/installer/setup/update_active_setup_version_work_item.h ('k') | chrome/installer/util/BUILD.gn » ('j') | chrome/installer/util/conditional_work_item_list.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/installer/setup/update_active_setup_version_work_item.cc

diff --git a/chrome/installer/setup/update_active_setup_version_work_item.cc b/chrome/installer/setup/update_active_setup_version_work_item.cc

index 7372675a6fe013ac72632f24f30df1dfb54cb1b4..293c82a0139ee926c2e800d0d03d04c9fab0cd6f 100644

--- a/chrome/installer/setup/update_active_setup_version_work_item.cc

+++ b/chrome/installer/setup/update_active_setup_version_work_item.cc

@@ -38,11 +38,11 @@ UpdateActiveSetupVersionWorkItem::UpdateActiveSetupVersionWorkItem(

operation_(operation) {

}

-bool UpdateActiveSetupVersionWorkItem::Do() {

+bool UpdateActiveSetupVersionWorkItem::DoImpl() {

return set_reg_value_work_item_.Do();

grt (UTC plus 2) 2016/04/27 17:29:16 should this propagate its state to the WI it deleg

fdoray 2016/05/02 20:10:00 Done.

}

-void UpdateActiveSetupVersionWorkItem::Rollback() {

+void UpdateActiveSetupVersionWorkItem::RollbackImpl() {

set_reg_value_work_item_.Rollback();

}