Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1882843002: [GN/iOS] Create a symlink to iossim for compatibility with gyp. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-iossim
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN/iOS] Create a symlink to iossim for compatibility with gyp. Add a //testing/iossim target on the default_toolchain that symlink to //testing/iossim($host_toolchain) for compatibility with gyp and bots. BUG=459705 Committed: https://crrev.com/89488f08f90710c57e40e4ef81a19d35914d374b Cr-Commit-Position: refs/heads/master@{#387201}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -43 lines) Patch
M build/config/ios/rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M testing/iossim/BUILD.gn View 1 chunk +51 lines, -42 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
sdefresne
Please take a look.
4 years, 8 months ago (2016-04-13 15:06:48 UTC) #2
sdefresne
Please send to CQ if you do not have any additional comments.
4 years, 8 months ago (2016-04-13 17:08:41 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-14 00:51:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882843002/20001
4 years, 8 months ago (2016-04-14 00:52:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-14 01:38:02 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 01:40:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89488f08f90710c57e40e4ef81a19d35914d374b
Cr-Commit-Position: refs/heads/master@{#387201}

Powered by Google App Engine
This is Rietveld 408576698