Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1890463002: [GN/iOS] Fix ios_web_unittests when building with gn. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-symlink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN/iOS] Fix ios_web_unittests when building with gn. Add ios/web/web_state/js/resources/post_request.js to js_resources when using gn (introduced by http://crrev.com/1375023002). Add missing //ios/web:ios_web_unittests_bundle_data to copy the test resources into the application bundle. BUG=459705 Committed: https://crrev.com/d2bbd878f8e259cb4d0537618f00557d46754f41 Cr-Commit-Position: refs/heads/master@{#387022}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master (to remove fake branch dependency) #

Patch Set 3 : Use more future proof outputs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ios/web/BUILD.gn View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
sdefresne
Please take a look.
4 years, 8 months ago (2016-04-13 15:32:09 UTC) #2
stkhapugin
lgtm
4 years, 8 months ago (2016-04-13 15:46:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890463002/40001
4 years, 8 months ago (2016-04-13 16:28:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1890463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1890463002/60001
4 years, 8 months ago (2016-04-13 17:07:42 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-13 17:46:10 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 17:47:21 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d2bbd878f8e259cb4d0537618f00557d46754f41
Cr-Commit-Position: refs/heads/master@{#387022}

Powered by Google App Engine
This is Rietveld 408576698