Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1880393004: [iOS/GN] Fix ios_chrome_unittests to pass when build with gn. (Closed)

Created:
4 years, 8 months ago by sdefresne
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-symlink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Fix ios_chrome_unittests to pass when build with gn. Change compile_xib template to work with different types of xib files (some do generate xxx.nib/... while other just generate a single xxx.nib). Add resources required by ios_chrome_unittests to the application bundle including compiled native_content_controller_test.xib. BUG=546283, 459705 Committed: https://crrev.com/2cb71a8ba37fd387113fb2b9f2407f750be158dc Cr-Commit-Position: refs/heads/master@{#387264}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M build/config/ios/rules.gni View 2 chunks +3 lines, -5 lines 0 comments Download
M ios/chrome/BUILD.gn View 3 chunks +20 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look.
4 years, 8 months ago (2016-04-13 17:20:11 UTC) #2
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-14 00:45:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880393004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880393004/1
4 years, 8 months ago (2016-04-14 08:24:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-14 08:45:57 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 08:46:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2cb71a8ba37fd387113fb2b9f2407f750be158dc
Cr-Commit-Position: refs/heads/master@{#387264}

Powered by Google App Engine
This is Rietveld 408576698