Issue 1882733004: Add OpenTypeCapsSupport class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1882733004: Add OpenTypeCapsSupport class (Closed)

Created:
4 years, 8 months ago by drott

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add OpenTypeCapsSupport class As preparation for implementing correct font-variant-caps we need to be able to check font files for their ability to support caps related OpenType features, such as 'smcp', 'c2sc' etc. The implementation files are split in two, one part Chromium-side implementation, one part Mozilla Public License'd code adapted from Firefox. Relanding this after revert in https://codereview.chromium.org/1891613002/ due to broken blink_platform_unittests. Splitting out the test into a separate CL in order to investigate a possible swarming/isolate step issue. BUG=587094 TEST=OpenTypeCapsSupportTest.cpp

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+316 lines, -0 lines)			Patch
M	third_party/WebKit/Source/platform/blink_platform.gypi	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/fonts/FontDescription.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.h	View	1 chunk	+57 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupport.cpp	View	1 chunk	+173 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/fonts/opentype/OpenTypeCapsSupportMPL.cpp	View	1 chunk	+81 lines, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1301453003 Patch 1