Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1301453003: Fix encoding issue in check_git_config (Closed)

Created:
5 years, 4 months ago by drott
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix encoding issue in check_git_config Fix for "Unicode equal comparison failed to convert both arguments to Unicode" when the git username contains non-ascii characters. Fixed by utf-8 decoding data imported from git. BUG=521519 Committed: https://crrev.com/7813ff35ac515acf6bf5e282081d5a9a54b30fc7 Cr-Commit-Position: refs/heads/master@{#343836}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/check_git_config.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
drott
5 years, 4 months ago (2015-08-17 08:58:47 UTC) #2
Vadim Sh.
lgtm, thanks
5 years, 4 months ago (2015-08-17 17:40:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301453003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301453003/1
5 years, 4 months ago (2015-08-18 06:14:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 06:27:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 06:27:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7813ff35ac515acf6bf5e282081d5a9a54b30fc7
Cr-Commit-Position: refs/heads/master@{#343836}

Powered by Google App Engine
This is Rietveld 408576698