Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1882593002: Make is_ktx safer (Closed)

Created:
4 years, 8 months ago by scroggo_chromium
Modified:
4 years, 8 months ago
Reviewers:
scroggo, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make is_ktx safer Rather than assuming the data passed to ktx at least KTX_FILE_IDENTIFIER_SIZE, pass the length of the data to is_ktx and compare it. Splitting off from crrev.com/1862133002, which no longer depends on is_ktx. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1882593002 Committed: https://skia.googlesource.com/skia/+/b8e0960de41be52b3e6c85f08fdc722925c70941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkKTXImageEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/ktx/ktx.h View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/ktx/ktx.cpp View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo_chromium
4 years, 8 months ago (2016-04-12 14:00:39 UTC) #3
robertphillips
lgtm
4 years, 8 months ago (2016-04-12 14:12:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882593002/1
4 years, 8 months ago (2016-04-12 14:31:30 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:41:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b8e0960de41be52b3e6c85f08fdc722925c70941

Powered by Google App Engine
This is Rietveld 408576698