src/images/SkKTXImageEncoder.cpp - Issue 1882593002: Make is_ktx safer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkKTXImageEncoder.cpp

Issue 1882593002: Make is_ktx safer (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkKTXImageEncoder.cpp

diff --git a/src/images/SkKTXImageEncoder.cpp b/src/images/SkKTXImageEncoder.cpp

index 5dc347ad66ff6c5c8bc406ead18d5b89e597447d..4b318a240c4ce6a764670d5736dfcdd7a631b35a 100644

--- a/src/images/SkKTXImageEncoder.cpp

+++ b/src/images/SkKTXImageEncoder.cpp

@@ -56,7 +56,7 @@ bool SkKTXImageEncoder::onEncode(SkWStream* stream, const SkBitmap& bitmap, int)

}

// Is it a KTX file??

- if (SkKTXFile::is_ktx(bytes)) {

+ if (SkKTXFile::is_ktx(bytes, data->size())) {

return stream->write(bytes, data->size());

}

« no previous file with comments | « src/gpu/SkGr.cpp ('k') | third_party/ktx/ktx.h » ('j') | no next file with comments »