src/gpu/SkGr.cpp - Issue 1882593002: Make is_ktx safer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/SkGr.cpp

Issue 1882593002: Make is_ktx safer (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/SkGr.cpp

diff --git a/src/gpu/SkGr.cpp b/src/gpu/SkGr.cpp

index 716909133a733d28bb03efafe13d214384e47d98..84023ecbb6cd0c8ce8d7d1c5aa16081a0dbd6549 100644

--- a/src/gpu/SkGr.cpp

+++ b/src/gpu/SkGr.cpp

@@ -87,7 +87,7 @@ GrPixelConfig GrIsCompressedTextureDataSupported(GrContext* ctx, SkData* data,

*outStartOfDataToUpload = bytes + ETC_PKM_HEADER_SIZE;

return kETC1_GrPixelConfig;

- } else if (SkKTXFile::is_ktx(bytes)) {

+ } else if (SkKTXFile::is_ktx(bytes, data->size())) {

SkKTXFile ktx(data);

// Is it actually an ETC1 texture?

« no previous file with comments | « no previous file | src/images/SkKTXImageEncoder.cpp » ('j') | no next file with comments »