Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1882533004: 🐍 Fix GN deps needed by third_party/WebKit/Tools/Scripts/run-webkit-tests (Closed)

Created:
4 years, 8 months ago by agrieve
Modified:
4 years, 8 months ago
Reviewers:
Dirk Pranke, Mike West
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Dirk Pranke, Peter Beverloo, jam, darin-cc_chromium.org, mikecase+watch_chromium.org, blink-reviews, mkwst+moarreviews-shell_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GN deps needed by third_party/WebKit/Tools/Scripts/run-webkit-tests BUG=587083 TBR=mkwst Committed: https://crrev.com/993374cf1ac90ef6fbb188017ea2fb445cf0eb09 Cr-Commit-Position: refs/heads/master@{#386870}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -53 lines) Patch
M BUILD.gn View 3 chunks +8 lines, -13 lines 0 comments Download
M build/symlink.gni View 2 chunks +15 lines, -5 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +15 lines, -18 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 2 chunks +2 lines, -2 lines 1 comment Download
A tools/android/forwarder/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
M tools/android/forwarder2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/md5sum/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M tools/imagediff/BUILD.gn View 1 chunk +24 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
agrieve
mkwst@chromium.org: Please review changes in content/shell dpranke@chromium.org: Please review changes in everywhere else
4 years, 8 months ago (2016-04-12 20:34:59 UTC) #2
agrieve
On 2016/04/12 20:34:59, agrieve wrote: > mailto:mkwst@chromium.org: Please review changes in content/shell > > mailto:dpranke@chromium.org: ...
4 years, 8 months ago (2016-04-12 20:36:17 UTC) #3
agrieve
https://codereview.chromium.org/1882533004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py (left): https://codereview.chromium.org/1882533004/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py#oldcode175 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py:175: return ['content_resources.pak', 'content_shell.pak', 'shell_resources.pak'] Android shouldn't need these to ...
4 years, 8 months ago (2016-04-12 20:36:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882533004/1
4 years, 8 months ago (2016-04-12 20:37:45 UTC) #6
Dirk Pranke
lgtm.
4 years, 8 months ago (2016-04-12 20:53:59 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-12 21:42:41 UTC) #9
agrieve
On 2016/04/12 21:42:41, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 8 months ago (2016-04-12 23:58:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882533004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882533004/1
4 years, 8 months ago (2016-04-12 23:59:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 00:05:51 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 00:07:15 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/993374cf1ac90ef6fbb188017ea2fb445cf0eb09
Cr-Commit-Position: refs/heads/master@{#386870}

Powered by Google App Engine
This is Rietveld 408576698