Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py

Issue 1882533004: 🐍 Fix GN deps needed by third_party/WebKit/Tools/Scripts/run-webkit-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/BUILD.gn ('k') | tools/android/forwarder/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
index a7591c11a4bcc88ca4574df91e191bf3a4ad4f14..c62e0bda19f311dc1be7aef38c30320a1aa4957e 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
@@ -172,7 +172,7 @@ class ContentShellDriverDetails():
return 'libcontent_shell_content_view.so'
def additional_resources(self):
- return ['content_resources.pak', 'content_shell.pak', 'shell_resources.pak']
agrieve 2016/04/12 20:36:47 Android shouldn't need these to be side-loaded sin
+ return []
def command_line_file(self):
return '/data/local/tmp/content-shell-command-line'
@@ -940,7 +940,7 @@ class ChromiumAndroidDriver(driver.Driver):
return [line.split(' ')[0] for line in md5sum_output]
def _files_match(self, host_file, device_file):
- assert self._port.host.filesystem.exists(host_file)
+ assert self._port.host.filesystem.exists(host_file), host_file
device_hashes = self._extract_hashes_from_md5sum_output(
self._port.host.executive.popen(self._android_commands.adb_command() + ['shell', MD5SUM_DEVICE_PATH, device_file],
stdout=subprocess.PIPE).stdout)
« no previous file with comments | « content/shell/BUILD.gn ('k') | tools/android/forwarder/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698