Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: BUILD.gn

Issue 1882533004: 🐍 Fix GN deps needed by third_party/WebKit/Tools/Scripts/run-webkit-tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index b017c947eb5bd33f379dc35cc8db7c966cf0b5fd..9e471e11c119eee65fd2027209c2db658e82b57f 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -293,7 +293,6 @@ group("both_gn_and_gyp") {
"//tools/android/heap_profiler:heap_profiler_unittests",
"//tools/android/kerberos/SpnegoAuthenticator:spnego_authenticator_apk",
"//tools/cygprofile:cygprofile_unittests",
- "//tools/imagediff($host_toolchain)",
"//ui/android:ui_junit_tests",
]
deps -= [
@@ -787,7 +786,9 @@ if (!is_ios) {
testonly = true
deps = [
+ "//content/shell:content_shell",
"//third_party/WebKit/public:all_blink",
+ "//tools/imagediff",
]
# NOTE: The following deps are needed to run the layout tests
@@ -796,18 +797,12 @@ if (!is_ios) {
if (is_android) {
deps += [
"//breakpad:breakpad_unittests",
- "//breakpad:dump_syms($host_toolchain)",
- "//breakpad:microdump_stackwalk($host_toolchain)",
- "//breakpad:minidump_dump($host_toolchain)",
- "//breakpad:minidump_stackwalk($host_toolchain)",
- "//breakpad:symupload($host_toolchain)",
- "//content/shell/android:content_shell_apk",
- "//tools/imagediff($host_toolchain)",
- ]
- } else {
- deps += [
- "//content/shell:content_shell",
- "//tools/imagediff",
+ "//breakpad:dump_syms",
+ "//breakpad:microdump_stackwalk",
+ "//breakpad:minidump_dump",
+ "//breakpad:minidump_stackwalk",
+ "//breakpad:symupload",
+ "//tools/android/forwarder",
]
}
« no previous file with comments | « no previous file | build/symlink.gni » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698