Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1081)

Issue 1882453002: Port v8_optimized_debug to gn. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Port v8_optimized_debug to gn. Makes browser_tests --gtest_filter=CrSettingsBrowserTest.CrSettingsTest complete in a little over 8 seconds instead of timing out after 45s on my box. Without this patch, the test is much slower in gn builds than in gyp builds. v8/ part, goes with https://codereview.chromium.org/1880693003 BUG=chromium:586511 LOG=n Committed: https://crrev.com/61c6cbb9e1d1ce2c77eb6d590bd7ecfb94426611 Cr-Commit-Position: refs/heads/master@{#35415}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M BUILD.gn View 7 chunks +19 lines, -4 lines 1 comment Download

Messages

Total messages: 16 (7 generated)
Nico
4 years, 8 months ago (2016-04-11 22:20:22 UTC) #2
Nico
https://codereview.chromium.org/1882453002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1882453002/diff/1/BUILD.gn#newcode249 BUILD.gn:249: "TRACE_MAPS", From what I can tell, the gyp build ...
4 years, 8 months ago (2016-04-11 22:22:09 UTC) #3
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-11 22:24:30 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-12 13:33:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882453002/1
4 years, 8 months ago (2016-04-12 13:34:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13493)
4 years, 8 months ago (2016-04-12 13:38:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1882453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1882453002/1
4 years, 8 months ago (2016-04-12 13:39:28 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 13:47:52 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 13:49:32 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61c6cbb9e1d1ce2c77eb6d590bd7ecfb94426611
Cr-Commit-Position: refs/heads/master@{#35415}

Powered by Google App Engine
This is Rietveld 408576698