Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: BUILD.gn

Issue 1882453002: Port v8_optimized_debug to gn. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 9d9a96ca761b53b467f785942de54ff373b966f9..f985083ec0b440d65f9b5d95e0bef62131c17459 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -246,8 +246,11 @@ config("toolchain") {
"OBJECT_PRINT",
"VERIFY_HEAP",
"DEBUG",
- "OPTIMIZED_DEBUG",
+ "TRACE_MAPS",
Nico 2016/04/11 22:22:09 From what I can tell, the gyp build never defines
]
+ if (!v8_optimized_debug) {
+ defines += [ "ENABLE_SLOW_DCHECKS" ]
+ }
}
}
@@ -583,6 +586,10 @@ source_set("v8_nosnapshot") {
":features",
":toolchain",
]
+ if (!is_debug || v8_optimized_debug) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
}
source_set("v8_snapshot") {
@@ -621,6 +628,10 @@ source_set("v8_snapshot") {
":features",
":toolchain",
]
+ if (!is_debug || v8_optimized_debug) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
}
if (v8_use_external_startup_data) {
@@ -651,6 +662,10 @@ if (v8_use_external_startup_data) {
":features",
":toolchain",
]
+ if (!is_debug || v8_optimized_debug) {
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+ }
}
}
@@ -1734,7 +1749,7 @@ source_set("v8_base") {
":toolchain",
]
- if (!is_debug) {
+ if (!is_debug || v8_optimized_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
@@ -1836,7 +1851,7 @@ source_set("v8_libbase") {
":toolchain",
]
- if (!is_debug) {
+ if (!is_debug || v8_optimized_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
@@ -1907,7 +1922,7 @@ source_set("v8_libplatform") {
":toolchain",
]
- if (!is_debug) {
+ if (!is_debug || v8_optimized_debug) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698