Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1880693003: Port v8_optimized_debug to gn. (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port v8_optimized_debug to gn. Makes browser_tests --gtest_filter=CrSettingsBrowserTest.CrSettingsTest complete in a little over 8 seconds instead of timing out after 45s on my box. Without this patch, the test is much slower in gn builds than in gyp builds. src/ part, goes with https://codereview.chromium.org/1882453002 BUG=586511 Committed: https://crrev.com/abfb5d1f6e41a50e4be3731eb87436d483d27c71 Cr-Commit-Position: refs/heads/master@{#386524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build_overrides/v8.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Nico
4 years, 8 months ago (2016-04-11 22:20:38 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880693003/1
4 years, 8 months ago (2016-04-11 22:20:58 UTC) #5
Dirk Pranke
lgtm
4 years, 8 months ago (2016-04-11 22:23:16 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 23:16:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880693003/1
4 years, 8 months ago (2016-04-11 23:55:58 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 00:03:43 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 00:05:14 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/abfb5d1f6e41a50e4be3731eb87436d483d27c71
Cr-Commit-Position: refs/heads/master@{#386524}

Powered by Google App Engine
This is Rietveld 408576698