Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 188223002: Clean up WindowEventDispatcher some more. (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Clean up WindowEventDispatcher some more. . Eliminate the implementation of LayerAnimationObserver. It seems no one expects WED to be a LAO anymore. . Remove WindowTreeHostDelegate. This involves moving some of the functions to WTH, removing some completely, and moving the remainder to the WED public API. A little icky for now, but I plan to take a pass on cleaning up WED's public API once I get it pared down. . window_tree_host_x11_unittest provided an implementation of WTHD that was not WED. This is not a valid situation now since various functions in WTH now call directly through to WED. Replaced this with a simple EventHandler to test that events are being dispatched. R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255368 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255533

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -376 lines) Patch
M ash/cancel_mode.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/cancel_mode.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/first_run/desktop_cleaner.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/sticky_keys/sticky_keys_overlay_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/overview/window_overview.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/aura_demo/window_tree_host_mojo.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -4 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 1 2 3 4 7 chunks +9 lines, -30 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 2 3 4 5 6 7 6 chunks +39 lines, -92 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host.h View 1 2 3 4 5 chunks +2 lines, -9 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 2 3 4 5 6 10 chunks +31 lines, -28 lines 0 comments Download
M ui/aura/window_tree_host_delegate.h View 1 2 3 4 1 chunk +0 lines, -60 lines 0 comments Download
M ui/aura/window_tree_host_mac.mm View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_win.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 7 chunks +11 lines, -15 lines 0 comments Download
M ui/aura/window_tree_host_x11_unittest.cc View 1 2 3 4 5 6 7 8 9 8 chunks +71 lines, -106 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +7 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ben Goodger (Google)
6 years, 9 months ago (2014-03-06 15:12:19 UTC) #1
sky
Nice, LGTM
6 years, 9 months ago (2014-03-06 15:52:51 UTC) #2
Ben Goodger (Google)
Committed patchset #10 manually as r255368 (presubmit successful).
6 years, 9 months ago (2014-03-06 16:48:28 UTC) #3
Ben Goodger (Google)
A revert of this CL has been created in https://codereview.chromium.org/188853003/ by ben@chromium.org. The reason for ...
6 years, 9 months ago (2014-03-06 17:53:42 UTC) #4
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-06 21:24:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/188223002/150027
6 years, 9 months ago (2014-03-06 21:30:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/188223002/150027
6 years, 9 months ago (2014-03-06 22:10:16 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-06 22:46:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg
6 years, 9 months ago (2014-03-06 22:46:11 UTC) #9
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 9 months ago (2014-03-07 03:05:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/188223002/150027
6 years, 9 months ago (2014-03-07 03:08:16 UTC) #11
Ben Goodger (Google)
6 years, 9 months ago (2014-03-07 05:01:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #13 manually as r255533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698