Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: ui/aura/window_event_dispatcher.h

Issue 188223002: Clean up WindowEventDispatcher some more. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/remote_window_tree_host_win.cc ('k') | ui/aura/window_event_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window_event_dispatcher.h
diff --git a/ui/aura/window_event_dispatcher.h b/ui/aura/window_event_dispatcher.h
index 9fe917bdf4ea13894c671f611810b90ba7d4b678..7ea3d603bd052b713b34cb51640b54f07b420406 100644
--- a/ui/aura/window_event_dispatcher.h
+++ b/ui/aura/window_event_dispatcher.h
@@ -16,10 +16,7 @@
#include "ui/aura/aura_export.h"
#include "ui/aura/client/capture_delegate.h"
#include "ui/aura/window_tree_host.h"
-#include "ui/aura/window_tree_host_delegate.h"
#include "ui/base/cursor/cursor.h"
-#include "ui/compositor/compositor.h"
-#include "ui/compositor/layer_animation_observer.h"
#include "ui/events/event_constants.h"
#include "ui/events/event_processor.h"
#include "ui/events/event_targeter.h"
@@ -37,7 +34,6 @@ namespace ui {
class GestureEvent;
class GestureRecognizer;
class KeyEvent;
-class LayerAnimationSequence;
class MouseEvent;
class ScrollEvent;
class TouchEvent;
@@ -54,9 +50,7 @@ class WindowTargeter;
// event dispatch.
class AURA_EXPORT WindowEventDispatcher : public ui::EventProcessor,
public ui::GestureEventHelper,
- public ui::LayerAnimationObserver,
- public client::CaptureDelegate,
- public WindowTreeHostDelegate {
+ public client::CaptureDelegate {
public:
explicit WindowEventDispatcher(WindowTreeHost* host);
virtual ~WindowEventDispatcher();
@@ -79,11 +73,11 @@ class AURA_EXPORT WindowEventDispatcher : public ui::EventProcessor,
// types (although the latter is currently a no-op).
void RepostEvent(const ui::LocatedEvent& event);
- WindowTreeHostDelegate* AsWindowTreeHostDelegate();
-
// Invoked when the mouse events get enabled or disabled.
void OnMouseEventsEnableStateChanged(bool enabled);
+ void DispatchCancelModeEvent();
+
// Returns a target window for the given gesture event.
Window* GetGestureTarget(ui::GestureEvent* event);
@@ -139,6 +133,11 @@ class AURA_EXPORT WindowEventDispatcher : public ui::EventProcessor,
// coordinates. This may return a point outside the root window's bounds.
gfx::Point GetLastMouseLocationInRoot() const;
+ void OnHostLostMouseGrab();
+ // TODO(beng): replace with a window observer.
+ void OnHostResized(const gfx::Size& size);
+ void OnCursorMovedToRootLocation(const gfx::Point& root_location);
+
private:
FRIEND_TEST_ALL_PREFIXES(WindowEventDispatcherTest,
KeepTranslatedEventInRoot);
@@ -155,7 +154,7 @@ class AURA_EXPORT WindowEventDispatcher : public ui::EventProcessor,
};
// Updates the event with the appropriate transform for the device scale
- // factor. The WindowTreeHostDelegate dispatches events in the physical pixel
+ // factor. The WindowEventDispatcher dispatches events in the physical pixel
// coordinate. But the event processing from WindowEventDispatcher onwards
// happen in device-independent pixel coordinate. So it is necessary to update
// the event received from the host.
@@ -207,26 +206,6 @@ class AURA_EXPORT WindowEventDispatcher : public ui::EventProcessor,
virtual void DispatchPostponedGestureEvent(ui::GestureEvent* event) OVERRIDE;
virtual void DispatchCancelTouchEvent(ui::TouchEvent* event) OVERRIDE;
- // Overridden from ui::LayerAnimationObserver:
- virtual void OnLayerAnimationEnded(
- ui::LayerAnimationSequence* animation) OVERRIDE;
- virtual void OnLayerAnimationScheduled(
- ui::LayerAnimationSequence* animation) OVERRIDE;
- virtual void OnLayerAnimationAborted(
- ui::LayerAnimationSequence* animation) OVERRIDE;
-
- // Overridden from aura::WindowTreeHostDelegate:
- virtual void OnHostCancelMode() OVERRIDE;
- virtual void OnHostActivated() OVERRIDE;
- virtual void OnHostLostWindowCapture() OVERRIDE;
- virtual void OnHostLostMouseGrab() OVERRIDE;
- virtual void OnHostResized(const gfx::Size& size) OVERRIDE;
- virtual void OnCursorMovedToRootLocation(
- const gfx::Point& root_location) OVERRIDE;
- virtual WindowEventDispatcher* AsDispatcher() OVERRIDE;
- virtual const WindowEventDispatcher* AsDispatcher() const OVERRIDE;
- virtual ui::EventProcessor* GetEventProcessor() OVERRIDE;
-
// We hold and aggregate mouse drags and touch moves as a way of throttling
// resizes when HoldMouseMoves() is called. The following methods are used to
// dispatch held and newly incoming mouse and touch events, typically when an
« no previous file with comments | « ui/aura/remote_window_tree_host_win.cc ('k') | ui/aura/window_event_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698