Extension Error Piping - Blink: WebKit Side

Source/WebKit/chromium/src/ChromeClientImpl.cpp

Index: Source/WebKit/chromium/src/ChromeClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
index d188558913dc3aae02f5ca45d3484c247e4a8c74..9da24dec5cb770b7663e4a8b510b0190c3465d98 100644
--- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp
+++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
@@ -374,17 +374,21 @@ void ChromeClientImpl::setResizable(bool value)
     m_resizable = value;
 }
 
-void ChromeClientImpl::addMessageToConsole(MessageSource source,
-                                           MessageLevel level,
-                                           const String& message,
-                                           unsigned lineNumber,
-                                           const String& sourceID)
+bool ChromeClientImpl::shouldReportDetailedMessage(const String& source)
+{
+    return m_webView->client() && m_webView->client()->shouldReportDetailedMessage(source);

[pfeldman, 2013/07/17 09:09:38]

You should decide based on the context.

[Devlin, 2013/07/17 22:14:13]

Deciding based on v8::Context, rather than URL, is good when it's possible. 
Unfortunately, sometimes we can't pass the context.  This can happen in the case
of a content script causing an error - the ScriptState* (from which we would get
the V8 Context) passed in to PageConsole::addMessage() is NULL.  In these cases,
examining the URL can inform us whether or not the error came from an extension.

That being said, if we use both the context and the URL, we are able restrict
ourselves to chrome-extension:// urls, which addresses the concern you had with
the method.

+}
+
+void ChromeClientImpl::addMessageToConsole(
+    MessageSource source, MessageLevel level, const String& message,
+    unsigned lineNumber, const String& sourceID, const String& stackTrace)
 {
     if (m_webView->client()) {
         m_webView->client()->didAddMessageToConsole(
             WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
             sourceID,
-            lineNumber);
+            lineNumber,
+            stackTrace);
     }
 }