Extension Error Piping - Blink: WebKit Side

Source/WebKit/chromium/src/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 356 matching lines @@
 bool ChromeClientImpl::menubarVisible()
 {
     return m_menubarVisible;
 }
 
 void ChromeClientImpl::setResizable(bool value)
 {
     m_resizable = value;
 }
 
-void ChromeClientImpl::addMessageToConsole(MessageSource source,
-                                           MessageLevel level,
-                                           const String& message,
-                                           unsigned lineNumber,
-                                           const String& sourceID)
+bool ChromeClientImpl::shouldReportDetailedMessage(const String& source)
+{
+    return m_webView->client() && m_webView->client()->shouldReportDetailedMessage(source);

[pfeldman, 2013/07/17 09:09:38]

You should decide based on the context.

[Devlin, 2013/07/17 22:14:13]

Deciding based on v8::Context, rather than URL, is good when it's possible. 
Unfortunately, sometimes we can't pass the context.  This can happen in the case
of a content script causing an error - the ScriptState* (from which we would get
the V8 Context) passed in to PageConsole::addMessage() is NULL.  In these cases,
examining the URL can inform us whether or not the error came from an extension.

That being said, if we use both the context and the URL, we are able restrict
ourselves to chrome-extension:// urls, which addresses the concern you had with
the method.

+}
+
+void ChromeClientImpl::addMessageToConsole(
+    MessageSource source, MessageLevel level, const String& message,
+    unsigned lineNumber, const String& sourceID, const String& stackTrace)
 {
     if (m_webView->client()) {
         m_webView->client()->didAddMessageToConsole(
             WebConsoleMessage(static_cast<WebConsoleMessage::Level>(level), message),
             sourceID,
-            lineNumber);
+            lineNumber,
+            stackTrace);
     }
 }
 
 bool ChromeClientImpl::canRunBeforeUnloadConfirmPanel()
 {
     return !!m_webView->client();
 }
 
 bool ChromeClientImpl::runBeforeUnloadConfirmPanel(const String& message, Frame* frame)
 {
@@ skipping 625 matching lines @@
 {
 }
 
 void NavigatorContentUtilsClientImpl::registerProtocolHandler(const String& scheme, const String& baseURL, const String& url, const String& title)
 { 
     m_webView->client()->registerProtocolHandler(scheme, baseURL, url, title);
 } 
 #endif
 
 } // namespace WebKit