Source/WebKit/chromium/src/ChromeClientImpl.h - Issue 18822004: Extension Error Piping - Blink: WebKit Side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebKit/chromium/src/ChromeClientImpl.h

Issue 18822004: Extension Error Piping - Blink: WebKit Side (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Consolidate [did]AddMessageToConsole() and reportDetailedMessage() Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/WebKit/chromium/src/ChromeClientImpl.h

diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.h b/Source/WebKit/chromium/src/ChromeClientImpl.h

index 7f12b918c8b4d94c9cee37dd877c75e921359308..3c0c9b7088884f87a019a1590bab301567275338 100644

--- a/Source/WebKit/chromium/src/ChromeClientImpl.h

+++ b/Source/WebKit/chromium/src/ChromeClientImpl.h

@@ -94,10 +94,11 @@ public:

virtual void setMenubarVisible(bool);

virtual bool menubarVisible();

virtual void setResizable(bool);

+ virtual bool shouldReportDetailedMessage(const WTF::String& source);

virtual void addMessageToConsole(

WebCore::MessageSource, WebCore::MessageLevel,

const WTF::String& message, unsigned lineNumber,

- const WTF::String& sourceID);

+ const WTF::String& sourceID, const WTF::String& stackTrace);

virtual bool canRunBeforeUnloadConfirmPanel();

virtual bool runBeforeUnloadConfirmPanel(

const WTF::String& message, WebCore::Frame*);