Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1881983003: Move PartitionAlloc related things into wtf/allocator. (Closed)

Created:
4 years, 8 months ago by esprehn
Modified:
4 years, 8 months ago
Reviewers:
haraken, dglazkov
CC:
Mads Ager (chromium), darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), haraken, hongchan, jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, kouhei+heap_chromium.org, leviw+bidiwatch_chromium.org, leviw+renderwatch, Mikhail, oilpan-reviews, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Raymond Toy, Stephen Chennney, sof, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PartitionAlloc related things into wtf/allocator. For now we leave Allocator.h in wtf since it's used in over 800 files. We'll move that separately. BUG=602508 Committed: https://crrev.com/51f1ed39a63558c7596387ef2822fa85dc9bc1a9 Cr-Commit-Position: refs/heads/master@{#386908}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -5649 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/CoreInitializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSTokenizerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XPathGrammar.y View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/xml/XSLTProcessorLibxslt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/MemoryPurgeController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PODArena.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PartitionAllocMemoryDumpProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioArray.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/GlyphPage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/CallbackStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/PageMemory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/BidiCharacterRun.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebKit.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/AddressSpaceRandomization.h View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/Source/wtf/AddressSpaceRandomization.cpp View 1 chunk +0 lines, -133 lines 0 comments Download
M third_party/WebKit/Source/wtf/Allocator.h View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/wtf/BitVector.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/HashMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/HashTable.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/LinkedHashSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ListHashSet.h View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/wtf/PageAllocator.h View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/WebKit/Source/wtf/PageAllocator.cpp View 1 chunk +0 lines, -277 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAlloc.h View 1 chunk +0 lines, -878 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAlloc.cpp View 1 chunk +0 lines, -1411 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAlloc.md View 1 chunk +0 lines, -97 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAllocTest.cpp View 1 chunk +0 lines, -1967 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAllocator.h View 1 chunk +0 lines, -224 lines 0 comments Download
D third_party/WebKit/Source/wtf/PartitionAllocator.cpp View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/WebKit/Source/wtf/Partitions.h View 1 chunk +0 lines, -153 lines 0 comments Download
D third_party/WebKit/Source/wtf/Partitions.cpp View 1 chunk +0 lines, -204 lines 0 comments Download
M third_party/WebKit/Source/wtf/TerminatedArray.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/ThreadSpecific.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Vector.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/WTF.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/AddressSpaceRandomization.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/AddressSpaceRandomization.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PageAllocator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PageAllocator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAlloc.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAlloc.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAlloc.md View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAllocTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAllocator.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/PartitionAllocator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/Partitions.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/wtf/allocator/Partitions.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/testing/RunAllTests.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/text/CString.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImplCF.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/wtf.gypi View 5 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881983003/1
4 years, 8 months ago (2016-04-13 00:15:16 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-13 01:46:24 UTC) #4
esprehn
4 years, 8 months ago (2016-04-13 02:05:09 UTC) #6
haraken
LGTM https://codereview.chromium.org/1881983003/diff/1/third_party/WebKit/Source/wtf/Allocator.h File third_party/WebKit/Source/wtf/Allocator.h (right): https://codereview.chromium.org/1881983003/diff/1/third_party/WebKit/Source/wtf/Allocator.h#newcode1 third_party/WebKit/Source/wtf/Allocator.h:1: // Copyright 2015 The Chromium Authors. All rights ...
4 years, 8 months ago (2016-04-13 02:32:53 UTC) #7
esprehn
On 2016/04/13 at 02:32:53, haraken wrote: > LGTM > > https://codereview.chromium.org/1881983003/diff/1/third_party/WebKit/Source/wtf/Allocator.h > File third_party/WebKit/Source/wtf/Allocator.h (right): ...
4 years, 8 months ago (2016-04-13 02:44:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1881983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1881983003/1
4 years, 8 months ago (2016-04-13 02:45:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-13 02:52:37 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 02:53:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51f1ed39a63558c7596387ef2822fa85dc9bc1a9
Cr-Commit-Position: refs/heads/master@{#386908}

Powered by Google App Engine
This is Rietveld 408576698