[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975
Committed: https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f
Cr-Commit-Position: refs/heads/master@{#387076}

[Evan Stade, 2016-04-12 00:56:58]

estade@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-04-12 00:56:59]

https://codereview.chromium.org/1881773002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc
(right):

https://codereview.chromium.org/1881773002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc:95: if
(!item_list.empty()) {
if https://codereview.chromium.org/1877143002/ lands first, you can probably
change the FillLayout to a (vertical) BoxLayout

[Devlin, 2016-04-13 00:39:45]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-04-13 00:47:30]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2016-04-13 00:47:30]

Finnur, mind taking a first look?  I'll look into the mac failures (and possibly
rebase on Evan's patch) tomorrow, but I expect the delta will be fairly small.

[Finnur, 2016-04-13 13:15:20]

Neat. LGTM.

[Devlin, 2016-04-13 20:16:29]

Description was changed from

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.

BUG=601975
==========

to

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975
==========

[Devlin, 2016-04-13 20:16:39]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-04-13 20:16:39]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1881773002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-13 20:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1881773002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1881773002/100001

[commit-bot: I haz the power, 2016-04-13 20:23:27]

Description was changed from

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975
==========

to

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975
==========

[commit-bot: I haz the power, 2016-04-13 20:23:28]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-04-13 20:25:56]

Description was changed from

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975
==========

to

==========
[Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles

Make ExtensionMessageBubbles use ToolbarActionsBarBubble on Views
platforms (we already do this on mac). In addition to meaning one less
bubble, the ToolbarActionsBarBubbleViews class is much more suited to
unit testing, since it doesn't require the full extensions system to
be in place.

Also add more unit tests.
TBR=sky@chromium.org (c/b/ui/views/settings_api_bubble_helper_views.cc,
reviewed by Finnur)

BUG=601975

Committed: https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f
Cr-Commit-Position: refs/heads/master@{#387076}
==========

[commit-bot: I haz the power, 2016-04-13 20:25:57]

Patchset 5 (id:??) landed as
https://crrev.com/5251920ddf61989a550ba9e49c8d1663a824a81f
Cr-Commit-Position: refs/heads/master@{#387076}