Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.cc

Issue 1881773002: [Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h" 5 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h"
6 6
7 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h" 7 #include "chrome/browser/ui/toolbar/toolbar_actions_bar_bubble_delegate.h"
8 #include "chrome/browser/ui/view_ids.h" 8 #include "chrome/browser/ui/view_ids.h"
9 #include "chrome/grit/locale_settings.h" 9 #include "chrome/grit/locale_settings.h"
10 #include "ui/base/resource/resource_bundle.h" 10 #include "ui/base/resource/resource_bundle.h"
11 #include "ui/views/controls/button/label_button.h" 11 #include "ui/views/controls/button/label_button.h"
12 #include "ui/views/controls/label.h" 12 #include "ui/views/controls/label.h"
13 #include "ui/views/controls/link.h"
13 #include "ui/views/layout/grid_layout.h" 14 #include "ui/views/layout/grid_layout.h"
14 #include "ui/views/layout/layout_constants.h" 15 #include "ui/views/layout/layout_constants.h"
15 16
17 namespace {
18 const int kListPadding = 10;
19 }
20
16 ToolbarActionsBarBubbleViews::ToolbarActionsBarBubbleViews( 21 ToolbarActionsBarBubbleViews::ToolbarActionsBarBubbleViews(
17 views::View* anchor_view, 22 views::View* anchor_view,
18 std::unique_ptr<ToolbarActionsBarBubbleDelegate> delegate) 23 std::unique_ptr<ToolbarActionsBarBubbleDelegate> delegate)
19 : views::BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT), 24 : views::BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
20 anchor_view_(anchor_view), 25 anchor_view_(anchor_view),
21 delegate_(std::move(delegate)), 26 delegate_(std::move(delegate)),
22 heading_label_(nullptr), 27 heading_label_(nullptr),
23 content_label_(nullptr), 28 content_label_(nullptr),
29 item_list_(nullptr),
30 learn_more_button_(nullptr),
24 dismiss_button_(nullptr), 31 dismiss_button_(nullptr),
25 action_button_(nullptr), 32 action_button_(nullptr),
26 acknowledged_(false) { 33 acknowledged_(false) {
27 set_close_on_deactivate(delegate_->ShouldCloseOnDeactivate()); 34 set_close_on_deactivate(delegate_->ShouldCloseOnDeactivate());
28 } 35 }
29 36
30 ToolbarActionsBarBubbleViews::~ToolbarActionsBarBubbleViews() {} 37 ToolbarActionsBarBubbleViews::~ToolbarActionsBarBubbleViews() {}
31 38
32 void ToolbarActionsBarBubbleViews::Show() { 39 void ToolbarActionsBarBubbleViews::Show() {
33 delegate_->OnBubbleShown(); 40 delegate_->OnBubbleShown();
34 GetWidget()->Show(); 41 GetWidget()->Show();
35 } 42 }
36 43
37 void ToolbarActionsBarBubbleViews::Init() { 44 void ToolbarActionsBarBubbleViews::Init() {
38 views::GridLayout* layout = new views::GridLayout(this); 45 views::GridLayout* layout = new views::GridLayout(this);
39 layout->SetInsets(views::kPanelVertMargin, views::kPanelHorizMargin, 46 layout->SetInsets(views::kPanelVertMargin, views::kPanelHorizMargin,
40 views::kPanelVertMargin, views::kPanelHorizMargin); 47 views::kPanelVertMargin, views::kPanelHorizMargin);
41 SetLayoutManager(layout); 48 SetLayoutManager(layout);
42 49
43 enum ColumnSetId { 50 enum ColumnSetId {
44 HEADER_AND_BODY_COLUMN_SET = 0, 51 HEADER_AND_BODY_COLUMN_SET = 0,
52 LIST_COLUMN_SET,
45 BUTTON_STRIP_COLUMN_SET, 53 BUTTON_STRIP_COLUMN_SET,
46 }; 54 };
47 55
48 views::ColumnSet* header_and_body_cs = 56 views::ColumnSet* header_and_body_cs =
49 layout->AddColumnSet(HEADER_AND_BODY_COLUMN_SET); 57 layout->AddColumnSet(HEADER_AND_BODY_COLUMN_SET);
50 header_and_body_cs->AddColumn(views::GridLayout::TRAILING, 58 header_and_body_cs->AddColumn(views::GridLayout::LEADING,
51 views::GridLayout::LEADING, 1, 59 views::GridLayout::LEADING, 1,
52 views::GridLayout::USE_PREF, 0, 0); 60 views::GridLayout::USE_PREF, 0, 0);
53 views::ColumnSet* buttons_cs = layout->AddColumnSet(BUTTON_STRIP_COLUMN_SET); 61 views::ColumnSet* buttons_cs = layout->AddColumnSet(BUTTON_STRIP_COLUMN_SET);
62 buttons_cs->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
63 0, views::GridLayout::USE_PREF, 0, 0);
54 buttons_cs->AddPaddingColumn(1, 0); 64 buttons_cs->AddPaddingColumn(1, 0);
55 buttons_cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::LEADING, 65 buttons_cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
56 0, views::GridLayout::USE_PREF, 0, 0); 66 0, views::GridLayout::USE_PREF, 0, 0);
57 buttons_cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing); 67 buttons_cs->AddPaddingColumn(0, views::kRelatedButtonHSpacing);
58 buttons_cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::LEADING, 68 buttons_cs->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
59 0, views::GridLayout::USE_PREF, 0, 0); 69 0, views::GridLayout::USE_PREF, 0, 0);
60 70
61 // Add a header. 71 // Add a header.
62 layout->StartRow(0, HEADER_AND_BODY_COLUMN_SET); 72 layout->StartRow(0, HEADER_AND_BODY_COLUMN_SET);
63 heading_label_ = new views::Label(delegate_->GetHeadingText()); 73 heading_label_ = new views::Label(delegate_->GetHeadingText());
64 heading_label_->SetFontList( 74 heading_label_->SetFontList(
65 ui::ResourceBundle::GetSharedInstance().GetFontList( 75 ui::ResourceBundle::GetSharedInstance().GetFontList(
66 ui::ResourceBundle::MediumFont)); 76 ui::ResourceBundle::MediumFont));
67 heading_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT); 77 heading_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
68 layout->AddView(heading_label_); 78 layout->AddView(heading_label_);
69 layout->AddPaddingRow(0, views::kLabelToControlVerticalSpacing); 79 layout->AddPaddingRow(0, views::kLabelToControlVerticalSpacing);
70 int width = views::Widget::GetLocalizedContentsWidth( 80 int width = views::Widget::GetLocalizedContentsWidth(
71 IDS_EXTENSION_TOOLBAR_REDESIGN_NOTIFICATION_BUBBLE_WIDTH_CHARS); 81 IDS_EXTENSION_TOOLBAR_REDESIGN_NOTIFICATION_BUBBLE_WIDTH_CHARS);
72 82
73 // Add the content string. 83 // Add the content string.
74 layout->StartRow(0, HEADER_AND_BODY_COLUMN_SET); 84 layout->StartRow(0, HEADER_AND_BODY_COLUMN_SET);
75 content_label_ = new views::Label( 85 content_label_ = new views::Label(
76 delegate_->GetBodyText(anchor_view_->id() == VIEW_ID_BROWSER_ACTION)); 86 delegate_->GetBodyText(anchor_view_->id() == VIEW_ID_BROWSER_ACTION));
77 content_label_->SetMultiLine(true); 87 content_label_->SetMultiLine(true);
78 content_label_->SizeToFit(width); 88 content_label_->SizeToFit(width);
79 content_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT); 89 content_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
80 layout->AddView(content_label_); 90 layout->AddView(content_label_);
91
92 base::string16 item_list = delegate_->GetItemListText();
93 if (!item_list.empty()) {
94 views::ColumnSet* list_cs = layout->AddColumnSet(LIST_COLUMN_SET);
95 list_cs->AddPaddingColumn(0, kListPadding);
96 list_cs->AddColumn(views::GridLayout::LEADING,
97 views::GridLayout::CENTER,
98 0,
99 views::GridLayout::USE_PREF,
100 0, 0);
101
102 layout->StartRowWithPadding(0, LIST_COLUMN_SET, 0, 0);
103 item_list_ = new views::Label(item_list);
104 item_list_->SetMultiLine(true);
105 item_list_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
106 item_list_->SizeToFit(width);
107 layout->AddView(item_list_);
108 }
109
81 layout->AddPaddingRow(0, views::kLabelToControlVerticalSpacing); 110 layout->AddPaddingRow(0, views::kLabelToControlVerticalSpacing);
82 111
83 layout->StartRow(0, BUTTON_STRIP_COLUMN_SET); 112 layout->StartRow(0, BUTTON_STRIP_COLUMN_SET);
113 base::string16 learn_more_text = delegate_->GetLearnMoreButtonText();
114 if (!learn_more_text.empty()) {
115 learn_more_button_ = new views::Link(learn_more_text);
116 learn_more_button_->set_listener(this);
117 layout->AddView(learn_more_button_);
118 } else {
119 layout->SkipColumns(1);
120 }
121
84 base::string16 dismiss_button_text = delegate_->GetDismissButtonText(); 122 base::string16 dismiss_button_text = delegate_->GetDismissButtonText();
85 if (!dismiss_button_text.empty()) { 123 if (!dismiss_button_text.empty()) {
86 dismiss_button_ = new views::LabelButton(this, dismiss_button_text); 124 dismiss_button_ = new views::LabelButton(this, dismiss_button_text);
87 dismiss_button_->SetStyle(views::Button::STYLE_BUTTON); 125 dismiss_button_->SetStyle(views::Button::STYLE_BUTTON);
88 layout->AddView(dismiss_button_, 1, 1, views::GridLayout::TRAILING, 126 layout->AddView(dismiss_button_, 1, 1, views::GridLayout::TRAILING,
89 views::GridLayout::FILL); 127 views::GridLayout::FILL);
90 } else { 128 } else {
91 layout->SkipColumns(1); 129 layout->SkipColumns(1);
92 } 130 }
93 131
(...skipping 11 matching lines...) Expand all
105 close_reason() == CloseReason::DEACTIVATION 143 close_reason() == CloseReason::DEACTIVATION
106 ? ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION 144 ? ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_DEACTIVATION
107 : ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION; 145 : ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION;
108 delegate_->OnBubbleClosed(close_action); 146 delegate_->OnBubbleClosed(close_action);
109 acknowledged_ = true; 147 acknowledged_ = true;
110 } 148 }
111 } 149 }
112 150
113 void ToolbarActionsBarBubbleViews::ButtonPressed(views::Button* sender, 151 void ToolbarActionsBarBubbleViews::ButtonPressed(views::Button* sender,
114 const ui::Event& event) { 152 const ui::Event& event) {
115 delegate_->OnBubbleClosed(ToolbarActionsBarBubbleDelegate::CLOSE_EXECUTE); 153 if (sender == action_button_) {
154 delegate_->OnBubbleClosed(ToolbarActionsBarBubbleDelegate::CLOSE_EXECUTE);
155 } else {
156 DCHECK_EQ(dismiss_button_, sender);
157 delegate_->OnBubbleClosed(
158 ToolbarActionsBarBubbleDelegate::CLOSE_DISMISS_USER_ACTION);
159 }
116 acknowledged_ = true; 160 acknowledged_ = true;
117 GetWidget()->Close(); 161 GetWidget()->Close();
118 } 162 }
163
164 void ToolbarActionsBarBubbleViews::LinkClicked(views::Link* link,
165 int event_flags) {
166 delegate_->OnBubbleClosed(ToolbarActionsBarBubbleDelegate::CLOSE_LEARN_MORE);
167 acknowledged_ = true;
168 GetWidget()->Close();
169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698