Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: chrome/browser/ui/views/settings_api_bubble_helper_views.cc

Issue 1881773002: [Extensions UI] Convert ExtensionMessageBubbles to ToolbarActionsBarBubbles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/settings_api_bubble_helper_views.h" 5 #include "chrome/browser/ui/views/settings_api_bubble_helper_views.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h" 10 #include "chrome/browser/extensions/ntp_overridden_bubble_delegate.h"
11 #include "chrome/browser/extensions/settings_api_bubble_delegate.h" 11 #include "chrome/browser/extensions/settings_api_bubble_delegate.h"
12 #include "chrome/browser/extensions/settings_api_helpers.h" 12 #include "chrome/browser/extensions/settings_api_helpers.h"
13 #include "chrome/browser/ui/browser_finder.h" 13 #include "chrome/browser/ui/browser_finder.h"
14 #include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h" 14 #include "chrome/browser/ui/extensions/extension_message_bubble_bridge.h"
15 #include "chrome/browser/ui/tabs/tab_strip_model.h" 15 #include "chrome/browser/ui/tabs/tab_strip_model.h"
16 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
17 #include "chrome/browser/ui/views/frame/browser_view.h" 16 #include "chrome/browser/ui/views/frame/browser_view.h"
18 #include "chrome/browser/ui/views/toolbar/app_menu_button.h" 17 #include "chrome/browser/ui/views/toolbar/app_menu_button.h"
19 #include "chrome/browser/ui/views/toolbar/home_button.h" 18 #include "chrome/browser/ui/views/toolbar/home_button.h"
19 #include "chrome/browser/ui/views/toolbar/toolbar_actions_bar_bubble_views.h"
20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h" 20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
21 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h" 21 #include "chrome/common/extensions/manifest_handlers/settings_overrides_handler. h"
22 #include "chrome/common/url_constants.h" 22 #include "chrome/common/url_constants.h"
23 #include "content/public/browser/browser_url_handler.h" 23 #include "content/public/browser/browser_url_handler.h"
24 #include "content/public/browser/navigation_entry.h" 24 #include "content/public/browser/navigation_entry.h"
25 25
26 namespace extensions { 26 namespace extensions {
27 27
28 namespace { 28 namespace {
29 29
30 void ShowSettingsApiBubble(SettingsApiOverrideType type, 30 void ShowSettingsApiBubble(SettingsApiOverrideType type,
31 Browser* browser, 31 Browser* browser,
32 views::View* anchor_view, 32 views::View* anchor_view,
33 views::BubbleBorder::Arrow arrow) { 33 views::BubbleBorder::Arrow arrow) {
34 std::unique_ptr<ExtensionMessageBubbleController> settings_api_bubble( 34 std::unique_ptr<ExtensionMessageBubbleController> settings_api_bubble(
35 new ExtensionMessageBubbleController( 35 new ExtensionMessageBubbleController(
36 new SettingsApiBubbleDelegate(browser->profile(), type), browser)); 36 new SettingsApiBubbleDelegate(browser->profile(), type), browser));
37 if (!settings_api_bubble->ShouldShow()) 37 if (!settings_api_bubble->ShouldShow())
38 return; 38 return;
39 39
40 ExtensionMessageBubbleView* bubble = new ExtensionMessageBubbleView( 40 // TODO(devlin): This should go through the ToolbarActionsBar.
41 anchor_view, arrow, 41 ToolbarActionsBarBubbleViews* bubble =
42 std::unique_ptr<ToolbarActionsBarBubbleDelegate>( 42 new ToolbarActionsBarBubbleViews(
43 new ExtensionMessageBubbleBridge(std::move(settings_api_bubble)))); 43 anchor_view,
44 scoped_ptr<ToolbarActionsBarBubbleDelegate>(
45 new ExtensionMessageBubbleBridge(
46 std::move(settings_api_bubble))));
47 bubble->set_arrow(arrow);
44 views::BubbleDelegateView::CreateBubble(bubble); 48 views::BubbleDelegateView::CreateBubble(bubble);
45 bubble->Show(); 49 bubble->Show();
46 } 50 }
47 51
48 } // namespace 52 } // namespace
49 53
50 void MaybeShowExtensionControlledHomeNotification(Browser* browser) { 54 void MaybeShowExtensionControlledHomeNotification(Browser* browser) {
51 #if !defined(OS_WIN) 55 #if !defined(OS_WIN)
52 return; 56 return;
53 #endif 57 #endif
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 &ignored_param); 107 &ignored_param);
104 if (ntp_url != active_url) 108 if (ntp_url != active_url)
105 return; // Not being overridden by an extension. 109 return; // Not being overridden by an extension.
106 110
107 std::unique_ptr<ExtensionMessageBubbleController> ntp_overridden_bubble( 111 std::unique_ptr<ExtensionMessageBubbleController> ntp_overridden_bubble(
108 new ExtensionMessageBubbleController( 112 new ExtensionMessageBubbleController(
109 new NtpOverriddenBubbleDelegate(browser->profile()), browser)); 113 new NtpOverriddenBubbleDelegate(browser->profile()), browser));
110 if (!ntp_overridden_bubble->ShouldShow()) 114 if (!ntp_overridden_bubble->ShouldShow())
111 return; 115 return;
112 116
113 ExtensionMessageBubbleView* bubble = new ExtensionMessageBubbleView( 117 ToolbarActionsBarBubbleViews* bubble =
118 new ToolbarActionsBarBubbleViews(
114 BrowserView::GetBrowserViewForBrowser(browser) 119 BrowserView::GetBrowserViewForBrowser(browser)
115 ->toolbar() 120 ->toolbar()
116 ->app_menu_button(), 121 ->app_menu_button(),
117 views::BubbleBorder::TOP_RIGHT,
118 std::unique_ptr<ToolbarActionsBarBubbleDelegate>( 122 std::unique_ptr<ToolbarActionsBarBubbleDelegate>(
119 new ExtensionMessageBubbleBridge(std::move(ntp_overridden_bubble)))); 123 new ExtensionMessageBubbleBridge(std::move(ntp_overridden_bubble))));
124 bubble->set_arrow(views::BubbleBorder::TOP_RIGHT);
120 views::BubbleDelegateView::CreateBubble(bubble); 125 views::BubbleDelegateView::CreateBubble(bubble);
121 bubble->Show(); 126 bubble->Show();
122 } 127 }
123 128
124 } // namespace extensions 129 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698