tools/perf/profile_creators/profile_generator.py - Issue 1881573002: [Perf] Guard against impending output_profile_path option move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/profile_generator.py

Issue 1881573002: [Perf] Guard against impending output_profile_path option move. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/profile_creators/profile_generator.py

diff --git a/tools/perf/profile_creators/profile_generator.py b/tools/perf/profile_creators/profile_generator.py

index 32e4dfde41b717efbbb08d836161fab2e53b619b..c8953e2686d0933b9f71ff761b39acc481909668 100644

--- a/tools/perf/profile_creators/profile_generator.py

+++ b/tools/perf/profile_creators/profile_generator.py

@@ -131,7 +131,12 @@ class ProfileGenerator(object):

# successful. In the generation process a temp directory is used so

# the default profile is not polluted on failure.

tmp_profile_path = tempfile.mkdtemp()

- creator_options.output_profile_path = tmp_profile_path

+ # TODO(eakuefner): Remove this after crrev.com/1874473006 rolls in.

+ try:

+ getattr(creator_options, 'output_profile_path')

+ creator_options.output_profile_path = tmp_profile_path

+ except AttributeError:

+ creator_options.browser_options.output_profile_path = tmp_profile_path

creator = self._profile_extender_class(creator_options)

« no previous file with comments | « tools/perf/profile_creators/profile_extender.py ('k') | no next file » | no next file with comments »