tools/perf/profile_creators/profile_extender.py - Issue 1881573002: [Perf] Guard against impending output_profile_path option move.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/profile_creators/profile_extender.py

Issue 1881573002: [Perf] Guard against impending output_profile_path option move. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/profile_creators/extension_profile_extender_unittest.py ('k') | tools/perf/profile_creators/profile_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/profile_creators/profile_extender.py

diff --git a/tools/perf/profile_creators/profile_extender.py b/tools/perf/profile_creators/profile_extender.py

index 4b5ef021fbf671f31d2e641f2155801c1a2284de..f1782af1454668d0de8ec355d86e3c1240841810 100644

--- a/tools/perf/profile_creators/profile_extender.py

+++ b/tools/perf/profile_creators/profile_extender.py

@@ -61,7 +61,9 @@ class ProfileExtender(object):

@property

def profile_path(self):

"""The path of the profile that the browser will use while it's running."""

- return self.finder_options.output_profile_path

+ # TODO(eakuefner): Remove this after crrev.com/1874473006 rolls in.

+ return getattr(self.finder_options, 'output_profile_path',

+ self.finder_options.browser_options.output_profile_path)

@property

def browser(self):