extensions/shell/app_shell.gyp - Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/app_shell.gyp

Issue 1881053002: Rework build/mac/tweak_info_plist.py to not rely on environment variables. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/app_shell.gyp

diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp

index fb8f05446919ab1b53c5786c4b72132ae013a3eb..6aaf295081d7561b407065c1b2f3fb4bb42ae963 100644

--- a/extensions/shell/app_shell.gyp

+++ b/extensions/shell/app_shell.gyp

@@ -172,6 +172,7 @@

# Modify the Info.plist as needed.

'postbuild_name': 'Tweak Info.plist',

'action': ['../../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--scm=1',

'--version=<(app_shell_version)'],

@@ -307,6 +308,7 @@

# but this seems like a really good place to store them.

'postbuild_name': 'Tweak Info.plist',

'action': ['../../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--breakpad=1',

'--keystone=0',

'--scm=1',

@@ -379,6 +381,7 @@

# never placed into the helper.

'postbuild_name': 'Tweak Info.plist',

'action': ['../../build/mac/tweak_info_plist.py',

+ '--plist=${TARGET_BUILD_DIR}/${INFOPLIST_PATH}',

'--breakpad=0',

'--keystone=0',

'--scm=0',

« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »