Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
index a08906340049ccf8956373ab5ca0999339a06bf2..6c54c042503d8260c2b900009cb704f4d2bbf04d 100644
--- a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
+++ b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
@@ -68,10 +68,10 @@ void TabDialogsCocoa::HideManagePasswordsBubble() {
// The bubble is closed when it loses the focus.
}
-std::unique_ptr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage(
+base::WeakPtr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage(
const gfx::Rect& anchor_in_root_view,
const base::string16& main_text,
const base::string16& sub_text) {
- return base::WrapUnique(new ValidationMessageBubbleCocoa(
- web_contents_, anchor_in_root_view, main_text, sub_text));
+ return (new ValidationMessageBubbleCocoa(
+ web_contents_, anchor_in_root_view, main_text, sub_text))->AsWeakPtr();
}
« no previous file with comments | « chrome/browser/ui/cocoa/tab_dialogs_cocoa.h ('k') | chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698