chrome/browser/ui/cocoa/tab_dialogs_cocoa.h - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_dialogs_cocoa.h

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tab_dialogs_cocoa.h

diff --git a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h

index 8dedc929d5d89a092f38c304f7dfb54d55ef5f67..820842dee7ba13085c04a2067982fa0b8e3af03b 100644

--- a/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h

+++ b/chrome/browser/ui/cocoa/tab_dialogs_cocoa.h

@@ -26,7 +26,7 @@ class TabDialogsCocoa : public TabDialogs {

ui::ProfileSigninConfirmationDelegate* delegate) override;

void ShowManagePasswordsBubble(bool user_action) override;

void HideManagePasswordsBubble() override;

- std::unique_ptr<ValidationMessageBubble> ShowValidationMessage(

+ base::WeakPtr<ValidationMessageBubble> ShowValidationMessage(

const gfx::Rect& anchor_in_root_view,

const base::string16& main_text,

const base::string16& sub_text) override;

« no previous file with comments | « chrome/browser/ui/browser.cc ('k') | chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm » ('j') | no next file with comments »