Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: msw review Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/tab_dialogs_cocoa.h" 5 #include "chrome/browser/ui/cocoa/tab_dialogs_cocoa.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #import "chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h" 8 #import "chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.h"
9 #import "chrome/browser/ui/cocoa/hung_renderer_controller.h" 9 #import "chrome/browser/ui/cocoa/hung_renderer_controller.h"
10 #import "chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h" 10 #import "chrome/browser/ui/cocoa/passwords/passwords_bubble_cocoa.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 61 }
62 62
63 void TabDialogsCocoa::ShowManagePasswordsBubble(bool user_action) { 63 void TabDialogsCocoa::ShowManagePasswordsBubble(bool user_action) {
64 ManagePasswordsBubbleCocoa::Show(web_contents_, user_action); 64 ManagePasswordsBubbleCocoa::Show(web_contents_, user_action);
65 } 65 }
66 66
67 void TabDialogsCocoa::HideManagePasswordsBubble() { 67 void TabDialogsCocoa::HideManagePasswordsBubble() {
68 // The bubble is closed when it loses the focus. 68 // The bubble is closed when it loses the focus.
69 } 69 }
70 70
71 std::unique_ptr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage( 71 base::WeakPtr<ValidationMessageBubble> TabDialogsCocoa::ShowValidationMessage(
72 const gfx::Rect& anchor_in_root_view, 72 const gfx::Rect& anchor_in_root_view,
73 const base::string16& main_text, 73 const base::string16& main_text,
74 const base::string16& sub_text) { 74 const base::string16& sub_text) {
75 return base::WrapUnique(new ValidationMessageBubbleCocoa( 75 return (new ValidationMessageBubbleCocoa(
76 web_contents_, anchor_in_root_view, main_text, sub_text)); 76 web_contents_, anchor_in_root_view, main_text, sub_text))->AsWeakPtr();
77 } 77 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/tab_dialogs_cocoa.h ('k') | chrome/browser/ui/cocoa/validation_message_bubble_cocoa.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698