chrome/browser/ui/browser.cc - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index b9d1732cd8684228650c2df23a39ddfc535cf2d2..9512433473b7a625f4b34d7545c992ed58b4836f 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -1276,7 +1276,8 @@ void Browser::ShowValidationMessage(content::WebContents* web_contents,

}

void Browser::HideValidationMessage(content::WebContents* web_contents) {

- validation_message_bubble_.reset();

+ if (validation_message_bubble_)

+ validation_message_bubble_->CloseValidationMessage();

}

void Browser::MoveValidationMessage(content::WebContents* web_contents,

« no previous file with comments | « chrome/browser/ui/browser.h ('k') | chrome/browser/ui/cocoa/tab_dialogs_cocoa.h » ('j') | no next file with comments »