chrome/browser/ui/browser.h - Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.h

Issue 1880853002: Convert ValidationMessageBubbleView to BubbleDialogDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msw review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.h

diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h

index 3cb7401123fcb5844fd59adc685f2e6920d6ed10..5c698601fcd821a579356d1b2d8a60e99a2f0e44 100644

--- a/chrome/browser/ui/browser.h

+++ b/chrome/browser/ui/browser.h

@@ -1002,7 +1002,7 @@ class Browser : public TabStripModelObserver,

// True if the browser window has been shown at least once.

bool window_has_shown_;

- std::unique_ptr<ValidationMessageBubble> validation_message_bubble_;

+ base::WeakPtr<ValidationMessageBubble> validation_message_bubble_;

SigninViewController signin_view_controller_;

« no previous file with comments | « no previous file | chrome/browser/ui/browser.cc » ('j') | no next file with comments »