Move to protocol::Vector

Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=

Committed: https://crrev.com/7b77df61133496c06995988ee2f5a1d8ad8384e9
Cr-Commit-Position: refs/heads/master@{#386869}

[eostroukhov-old, 2016-04-12 15:53:24]

eostroukhov@google.com changed reviewers:
+ kozyatinskiy@chromium.org

[pfeldman, 2016-04-12 16:54:48]

Description was changed from

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=
==========

to

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=
==========

[pfeldman, 2016-04-12 16:54:48]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-04-12 16:56:21]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-04-12 16:56:21]

lgtm

[kozy, 2016-04-12 17:09:59]

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h
(right):

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h:21:
size_t hash = 0;
StringHash::hash caches result. Can we add cache here?

[alph, 2016-04-12 19:05:24]

alph@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-04-12 19:05:25]

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h
(right):

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h:23: hash
+= 31 * k[i];
looks like a very bad hash. This is basically just 31*∑k[i], so lots of strings
will collide.

Consider:
hash = 31 * hash + k[i];
It is much better while being a simple enough.

[kozy, 2016-04-12 19:07:50]

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h
(right):

https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h:23: hash
+= 31 * k[i];
On 2016/04/12 19:05:25, alph wrote:
> looks like a very bad hash. This is basically just 31*∑k[i], so lots of
strings
> will collide.
> 
> Consider:
> hash = 31 * hash + k[i];
> It is much better while being a simple enough.

Or we can reuse calculateHash from V8DebuggerAgentImpl.cpp :)

[eostroukhov-old, 2016-04-12 19:20:15]

On 2016/04/12 19:07:50, kozyatinskiy wrote:
>
https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h
> (right):
> 
>
https://codereview.chromium.org/1880833002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/inspector_protocol/CollectionsSTL.h:23:
hash
> += 31 * k[i];
> On 2016/04/12 19:05:25, alph wrote:
> > looks like a very bad hash. This is basically just 31*∑k[i], so lots of
> strings
> > will collide.
> > 
> > Consider:
> > hash = 31 * hash + k[i];
> > It is much better while being a simple enough.
> 
> Or we can reuse calculateHash from V8DebuggerAgentImpl.cpp :)

Moved hash to String16STL.h. I will add that header in separate CL :)

[kozy, 2016-04-12 21:03:12]

lgtm

[eostroukhov-old, 2016-04-12 21:05:27]

The CQ bit was checked by eostroukhov@google.com

[eostroukhov-old, 2016-04-12 21:05:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1880833002/#ps40001
(title: "Moved hash to a String16STL.h (not yet in this repo)")

[commit-bot: I haz the power, 2016-04-12 21:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1880833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1880833002/40001

[commit-bot: I haz the power, 2016-04-12 23:59:19]

Description was changed from

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=
==========

to

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=
==========

[commit-bot: I haz the power, 2016-04-12 23:59:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-13 00:01:17]

Description was changed from

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=
==========

to

==========
Move to protocol::Vector

This change is required to reduce the reliance on the WTF::Vector in the
DevTools.
1. Debugger now uses protocol::Vector instead of WTF::Vector
2. Move ctor and swap(...) methods were added to a Vector specialization
   that keeps OwnPtr.

BUG=

Committed: https://crrev.com/7b77df61133496c06995988ee2f5a1d8ad8384e9
Cr-Commit-Position: refs/heads/master@{#386869}
==========

[commit-bot: I haz the power, 2016-04-13 00:01:19]

Patchset 3 (id:??) landed as
https://crrev.com/7b77df61133496c06995988ee2f5a1d8ad8384e9
Cr-Commit-Position: refs/heads/master@{#386869}