third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp - Issue 1880833002: Move to protocol::Vector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 1880833002: Move to protocol::Vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved hash to a String16STL.h (not yet in this repo) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

index 744759324af9fdff10fc59c25344f0a04430c688..5671c5b53eae297b1ef9dd8fc3741f8c9ed9ac6b 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

@@ -474,7 +474,7 @@ void V8DebuggerAgentImpl::getBacktrace(ErrorString* errorString, OwnPtr<Array<Ca

{

if (!assertPaused(errorString))

return;

- m_pausedCallFrames = debugger().currentCallFrames();

+ m_pausedCallFrames.swap(debugger().currentCallFrames());

*callFrames = currentCallFrames(errorString);

if (!*callFrames)

return;

@@ -649,8 +649,7 @@ void V8DebuggerAgentImpl::restartFrame(ErrorString* errorString,

*errorString = "Internal error";

return;

}

- m_pausedCallFrames = debugger().currentCallFrames();

+ m_pausedCallFrames.swap(debugger().currentCallFrames());

*newCallFrames = currentCallFrames(errorString);

if (!*newCallFrames)

@@ -1376,8 +1375,7 @@ V8DebuggerAgentImpl::SkipPauseRequest V8DebuggerAgentImpl::didPause(v8::Local<v8

return RequestContinue;

ASSERT(m_pausedContext.IsEmpty());

- callFrames = debugger().currentCallFrames();

- m_pausedCallFrames.swap(callFrames);

+ m_pausedCallFrames.swap(debugger().currentCallFrames());

m_pausedContext.Reset(m_isolate, context);

v8::HandleScope handles(m_isolate);