Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp

Issue 1880833002: Move to protocol::Vector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved hash to a String16STL.h (not yet in this repo) Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 391 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 } 402 }
403 ASSERT(!v8result.IsEmpty()); 403 ASSERT(!v8result.IsEmpty());
404 v8::Local<v8::Object> resultTuple = v8result->ToObject(m_isolate); 404 v8::Local<v8::Object> resultTuple = v8result->ToObject(m_isolate);
405 int code = static_cast<int>(resultTuple->Get(0)->ToInteger(m_isolate)->Value ()); 405 int code = static_cast<int>(resultTuple->Get(0)->ToInteger(m_isolate)->Value ());
406 switch (code) { 406 switch (code) {
407 case 0: 407 case 0:
408 { 408 {
409 *stackChanged = resultTuple->Get(1)->BooleanValue(); 409 *stackChanged = resultTuple->Get(1)->BooleanValue();
410 // Call stack may have changed after if the edited function was on t he stack. 410 // Call stack may have changed after if the edited function was on t he stack.
411 if (!preview && isPaused()) 411 if (!preview && isPaused())
412 *newCallFrames = currentCallFrames(); 412 newCallFrames->swap(currentCallFrames());
413 return true; 413 return true;
414 } 414 }
415 // Compile error. 415 // Compile error.
416 case 1: 416 case 1:
417 { 417 {
418 *errorData = protocol::Debugger::SetScriptSourceError::create() 418 *errorData = protocol::Debugger::SetScriptSourceError::create()
419 .setMessage(toProtocolStringWithTypeCheck(resultTuple->Get(2))) 419 .setMessage(toProtocolStringWithTypeCheck(resultTuple->Get(2)))
420 .setLineNumber(resultTuple->Get(3)->ToInteger(m_isolate)->Value( )) 420 .setLineNumber(resultTuple->Get(3)->ToInteger(m_isolate)->Value( ))
421 .setColumnNumber(resultTuple->Get(4)->ToInteger(m_isolate)->Valu e()).build(); 421 .setColumnNumber(resultTuple->Get(4)->ToInteger(m_isolate)->Valu e()).build();
422 return false; 422 return false;
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
824 } 824 }
825 825
826 const V8DebuggerImpl::ContextByIdMap* V8DebuggerImpl::contextGroup(int contextGr oupId) 826 const V8DebuggerImpl::ContextByIdMap* V8DebuggerImpl::contextGroup(int contextGr oupId)
827 { 827 {
828 if (!m_contexts.contains(contextGroupId)) 828 if (!m_contexts.contains(contextGroupId))
829 return nullptr; 829 return nullptr;
830 return m_contexts.get(contextGroupId); 830 return m_contexts.get(contextGroupId);
831 } 831 }
832 832
833 } // namespace blink 833 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698