Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1880453002: Reorder metrics iteration in LayoutSVGInlineText::updateMetricsList (Closed)

Created:
4 years, 8 months ago by fs
Modified:
4 years, 8 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-16
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reorder metrics iteration in LayoutSVGInlineText::updateMetricsList This changes iteration to iterate BidiRuns and then collect metrics for all characters in each run. BUG=594058 Committed: https://crrev.com/bd627c9a9d79a058525581fc88985da16082b8c7 Cr-Commit-Position: refs/heads/master@{#387283}

Patch Set 1 #

Patch Set 2 : charactersLength #

Patch Set 3 : And cast #

Patch Set 4 : Use the correct run length. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -141 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp View 1 2 3 6 chunks +57 lines, -141 lines 0 comments Download

Depends on Patchset:

Issue 1879453003 Patch 1

Messages

Total messages: 9 (3 generated)
fs
(Maybe) the way pdr intended it.
4 years, 8 months ago (2016-04-11 16:19:30 UTC) #2
fs
On 2016/04/11 at 16:19:30, fs wrote: > (Maybe) the way pdr intended it. Kerplunk
4 years, 8 months ago (2016-04-13 11:45:04 UTC) #3
pdr.
On 2016/04/13 at 11:45:04, fs wrote: > On 2016/04/11 at 16:19:30, fs wrote: > > ...
4 years, 8 months ago (2016-04-13 23:19:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1880453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1880453002/60001
4 years, 8 months ago (2016-04-14 08:17:30 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-14 11:30:05 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-14 11:31:45 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/bd627c9a9d79a058525581fc88985da16082b8c7
Cr-Commit-Position: refs/heads/master@{#387283}

Powered by Google App Engine
This is Rietveld 408576698