third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h - Issue 1880453002: Reorder metrics iteration in LayoutSVGInlineText::updateMetricsList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

Issue 1880453002: Reorder metrics iteration in LayoutSVGInlineText::updateMetricsList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-16

Patch Set: Use the correct run length. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

index b0738782296d8a2fbf6c52ae45e4b3a9b592e934..7ef1f3b4634608e6bc5a3bec8bbc69e045043e4f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.h

@@ -56,6 +56,8 @@ private:

void setTextInternal(PassRefPtr<StringImpl>) override;

void styleDidChange(StyleDifference, const ComputedStyle*) override;

+ void addMetricsFromRun(const TextRun&, bool& lastCharacterWasWhiteSpace);

FloatRect objectBoundingBox() const override { return floatLinesBoundingBox(); }

bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectSVG || type == LayoutObjectSVGInlineText || LayoutText::isOfType(type); }

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp » ('j') | no next file with comments »